Update deprecated CreateHeaderRaw to correctly call CreateRaw#502
Merged
klauspost merged 1 commit intoklauspost:masterfrom Feb 22, 2022
Merged
Update deprecated CreateHeaderRaw to correctly call CreateRaw#502klauspost merged 1 commit intoklauspost:masterfrom
klauspost merged 1 commit intoklauspost:masterfrom
Conversation
saracen
added a commit
to saracen/fastzip
that referenced
this pull request
Feb 21, 2022
This also now calls the newer CreateRaw() method, as CreateHeaderRaw() is now deprecated. This fixes #32, as when CreateHeaderRaw() was deprecated, it started calling the incorrect function that replaced it: klauspost/compress#502 A test with a larger content body has been added as it was able to detect this regression. Fixes #32
Owner
|
Thanks for the contrib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastzip had reports of malformed compressed data (saracen/fastzip#32). I've narrowed the fix down to this.
I'll update
fastzipto call the non-deprecated function now, but fixing this here is still a good idea. gitLab-runner uses fastzip and stumbled across this issue when theklauspost/compressdependency was indirectly updated via a minor minio upgrade. 😢