Repository navigation
docs(os-patch-sla): drop the target_group workaround notes after #177 - #197
Merged
Merged
Conversation
#177 removed the play var that shadowed the hosts: default, so staging/prod runs select their group from -e patch_stage again. Remove the -e target_group=<stage> reminders from spec section 1 and the section 7 SOP and add changelog v1.3. Checklist rows, Expected values and the targets table are unchanged. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
kjelly
marked this pull request as ready for review
October 29, 2026 15:51
Owner
Author
Automated PR review: Draft requiredReviewed HEAD: Blocking issues / verification notes
Next steps: Address blocking findings, rerun affected tests and CI, and request independent review on the updated HEAD/Base before marking Ready. This comment is an automated technical review, not a human approval. |
kjelly
marked this pull request as draft
October 30, 2026 02:15
…P commands Evidence-only follow-up to 505d527 (tree 2e5b2ac): check/diff, apply and idempotent re-apply on a fresh prod-group and a fresh staging-group VM without -e target_group=, with the committed spec verified (existing C1/C2/C4 failures recorded). The spec gains one line linking the record; checklist rows, commands and Expected values are unchanged. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #181 and #186 (both merged). #186 removed the play var that shadowed
hosts: "{{ target_group | default(patch_stage) }}", so the-e target_group=<stage>workaround that #181 documented indocs/verification/os-patch-sla.mdis no longer needed.-e target_group=; the paragraph explaining the shadowing is replaced by a one-line statement thatpatch_stageselects the group.ansible-playbookcommands drop-e target_group=.Checklist rows C1–C8, Expected values and the §1 targets table are unchanged.
Verification (actual run)
Tested candidate
505d527(tree2e5b2ac76c7d08401bb5268e65e6e055a3677930); record:docs/evidence/os-patch-sla/2026-10-30-505d527.md. Two fresh, never-applied Ubuntu 24.04 vm-target VMs, one whose only inventory group isprod, one whose only group isstaging, inventory facts read withshow-inventory. The documented commands ran without-e target_group=:--check --diff(fresh)failed=0failed=0changed=0failed=0failed=0changed=0The 3 failures are C1, C2 and C4: the golden image has 191 upgradable packages and no recent apt history, and apply never upgrades packages because Step 3 uses
unattended-upgrade --non-interactive, an option the installed version rejects (#172). Same shape as the earlier 2026-10-29 record; not caused by this change. Gates were also triggered on the prod VM: a mismatching stage selects no hosts, andpatch_stage=prodwithoutconfirm_prodfails the confirm gate.The commit after
505d527only adds the evidence record and the one link line in the spec; the playbook, test and all spec rows and commands are byte-identical (sha256 recorded in the record).🤖 Generated with Claude Code