Skip to content

Commit c45ed55

Browse files
committed
fix(edit): refresh SSSD cache on FreeIPA client after identity reconcile + multiselect empty-list UX fix
FreeIPA identity playbook now ends with sss_cache -E on every enrolled freeipa-client host so authorization changes become observable without waiting for SSSD cache expiry (inventory-driven, never hard-coded hosts). Also fixes multiselect TUI: Enter on an empty item list (valid for optional checklist fields) now submits an empty selection instead of silently ignoring the keystroke.
1 parent de61b7a commit c45ed55

4 files changed

Lines changed: 65 additions & 1 deletion

File tree

‎cmd/pilot/cmd/tui_multiselect.go‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,11 @@ func (m multiSelectModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
117117
m.items[itemIndex].Checked = !m.items[itemIndex].Checked
118118
}
119119
case "enter":
120-
if len(matches) > 0 {
120+
// An empty source list is a valid answer for optional checklist
121+
// fields (for example, a new sudo rule may use direct commands
122+
// without any command groups). A non-empty list filtered to zero
123+
// results is different: do not let Enter silently submit a typo.
124+
if len(matches) > 0 || len(m.items) == 0 {
121125
m.confirmed = true
122126
}
123127
case "esc", "ctrl+c":

‎cmd/pilot/cmd/tui_multiselect_test.go‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,18 @@ func TestMultiSelect_EmptyItemListDoesNotPanic(t *testing.T) {
170170
}
171171
}
172172

173+
func TestMultiSelect_EmptyItemListEnterFinishes(t *testing.T) {
174+
m := multiSelectModel{title: "optional empty checklist"}
175+
next, _ := m.Update(tea.KeyMsg{Type: tea.KeyEnter})
176+
m = next.(multiSelectModel)
177+
if !m.Finished() || m.Canceled() {
178+
t.Fatalf("empty checklist should accept Enter as an empty selection: finished=%t canceled=%t", m.Finished(), m.Canceled())
179+
}
180+
if got := m.CheckedLabels(); len(got) != 0 {
181+
t.Fatalf("empty checklist selected unexpected items: %v", got)
182+
}
183+
}
184+
173185
func TestMultiSelect_ViewShowsCheckboxMarks(t *testing.T) {
174186
m := newTestMultiSelect()
175187
view := m.View()

‎internal/spec/freeipa_identity_regression_test.go‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,3 +138,31 @@ func TestRegression_FreeipaIdentityAllowAllUsesCommandCategory(t *testing.T) {
138138
t.Fatal("allow.command_category: all must reconcile to FreeIPA cmdcat=all")
139139
}
140140
}
141+
142+
// TestRegression_FreeipaIdentityRefreshesClientSSSDCache locks the post-
143+
// reconcile hand-off: FreeIPA authorization changes must not remain hidden
144+
// behind stale client-side SSSD caches.
145+
func TestRegression_FreeipaIdentityRefreshesClientSSSDCache(t *testing.T) {
146+
const playbookPath = "../../playbooks/apply/freeipa-identity-apply.yml"
147+
raw, err := os.ReadFile(playbookPath)
148+
if err != nil {
149+
t.Fatalf("read %s: %v", playbookPath, err)
150+
}
151+
playbook := string(raw)
152+
for _, want := range []string{
153+
"ipa_identity_refresh_sssd_cache: true",
154+
`name: "Refresh SSSD caches on enrolled FreeIPA clients"`,
155+
"ansible.builtin.command: sss_cache -E",
156+
`delegate_to: "{{ item }}"`,
157+
`loop: "{{ groups.get('freeipa-client', []) }}"`,
158+
"become: true",
159+
"become_method: sudo",
160+
"- not ansible_check_mode",
161+
"- ipa_identity_refresh_sssd_cache | bool",
162+
"changed_when: false",
163+
} {
164+
if !strings.Contains(playbook, want) {
165+
t.Errorf("identity playbook must contain %q", want)
166+
}
167+
}
168+
}

‎playbooks/apply/freeipa-identity-apply.yml‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,12 @@
9191
# every user login to every host regardless of the rules above.
9292
ipa_hbac_disable_allow_all: false
9393

94+
# SSSD clients cache identity, HBAC, and sudo data. Refresh every
95+
# inventory-declared FreeIPA client after a successful identity reconcile
96+
# so authorization changes become observable without waiting for cache
97+
# expiry. This is intentionally inventory-driven; never hard-code hosts.
98+
ipa_identity_refresh_sssd_cache: true
99+
94100
pre_tasks:
95101
- name: "Load canonical roster under a namespace"
96102
ansible.builtin.include_vars:
@@ -1987,6 +1993,20 @@
19871993
tags: [identity, nfs, C18]
19881994

19891995
# ── Release ticket ─────────────────────────────────────────────────
1996+
- name: "Refresh SSSD caches on enrolled FreeIPA clients"
1997+
ansible.builtin.command: sss_cache -E
1998+
delegate_to: "{{ item }}"
1999+
become: true
2000+
become_method: sudo
2001+
loop: "{{ groups.get('freeipa-client', []) }}"
2002+
loop_control:
2003+
label: "{{ item }}"
2004+
changed_when: false
2005+
when:
2006+
- not ansible_check_mode
2007+
- ipa_identity_refresh_sssd_cache | bool
2008+
tags: [identity, client-cache]
2009+
19902010
- name: "Release the Kerberos ticket"
19912011
ansible.builtin.command: kdestroy
19922012
changed_when: false

0 commit comments

Comments
 (0)