You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 549b32e
Browse filesBrowse the repository at this point in the historyBrowse files
fix(skills): never rm -rf the shared VM image directory
Four vm-target-spec-testing passages told agents to run
`sudo rm -rf /var/lib/libvirt/images/pilot/<name>` after `vm-target down`,
and the clean-room contract's first teardown step removed every VM
"belonging to the runbook" before saying not to touch VMs you did not
create. On this host every clone and session shares the pilot data dir
and that image directory (`vm-target list` here shows other sessions'
VMs, and the directory holds other runs' leftovers and the base images),
so both could delete another session's VM.
The rm -rf was also never needed: `down` already removes the per-target
directory (teardown -> os.RemoveAll(t.Dir)), and nothing is shared
between host and VM, so a Docker bind mount inside the VM lives in the
overlay that down deletes. The "bind-mount survives vm-target down" trap
is rewritten as what it is: state that survives a re-run on the same VM,
cleared by `vm-target reset` or `down`.
- vm-target-spec-testing SKILL.md §8, vm-target-basics.md, container-in-
vmtesting.md Trap 3, case-study-freeipa.md: drop the rm -rf; down only
VMs this session created; a directory surviving down is a teardown bug
to report.
- clean-room contract §4 step 1: record VMs, remove only this run's own
or user-named disposable ones, use fresh names for the rest.
- TestDown_RemovesState now asserts the directory is gone (fails if
teardown stops removing it).
Checked on this host: `vm-target up`, a file written inside the VM,
`vm-target down` -> the per-target directory, libvirt domain and state
record are all gone.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
0 commit comments