Skip to content

feat(skills): dispute wrong claims, align PR and evidence gates, refresh VM and roster guidance #482

feat(skills): dispute wrong claims, align PR and evidence gates, refresh VM and roster guidance

feat(skills): dispute wrong claims, align PR and evidence gates, refresh VM and roster guidance #482

Triggered via pull request October 30, 2026 12:40
Status Success
Total duration 44m 37s
Artifacts 1

ci.yml

on: pull_request
Go test
41m 25s
Go test
Playbook lint
16m 57s
Playbook lint
Root-only ownership tests
24s
Root-only ownership tests
Thanos retention behavior
21s
Thanos retention behavior
golangci-lint
55s
golangci-lint
pilot-cli image
2m 52s
pilot-cli image
promote pilot-cli:latest
0s
promote pilot-cli:latest
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 9 warnings, and 6 notices
yaml[line-length]: playbooks/apply/audit-log-forwarding-apply.yml#L186
Line too long (366 > 160 characters)
name[template]: playbooks/apply/alertmanager-apply.yml#L327
Jinja templates should only be at the end of 'name'
name[missing]: playbooks/apply/alertmanager-apply.yml#L288
All tasks should be named.
yaml[line-length]: playbooks/apply/alertmanager-apply.yml#L220
Line too long (321 > 160 characters)
no-handler: playbooks/apply/agent-controller-apply.yml#L436
Tasks that run when changed should likely be handlers.
run-once[task]: playbooks/apply/agent-controller-apply.yml#L236
Using run_once may behave differently if strategy is set to free.
run-once[task]: playbooks/apply/agent-controller-apply.yml#L225
Using run_once may behave differently if strategy is set to free.
run-once[task]: playbooks/apply/agent-controller-apply.yml#L212
Using run_once may behave differently if strategy is set to free.
run-once[task]: playbooks/apply/agent-controller-apply.yml#L202
Using run_once may behave differently if strategy is set to free.
yaml[empty-lines]: playbooks/apply/agent-controller-apply.yml#L58
Too many blank lines (3 > 2)
Thanos retention behavior
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Root-only ownership tests
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-go@v5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
golangci-lint
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-go@v5, golangci/golangci-lint-action@v8. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Playbook lint
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-go@v5, actions/setup-python@v5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
jinja[spacing]: playbooks/apply/tasks/host-metrics-missing-probe-round-gate.yml#L111
Jinja2 spacing could be improved: {% for p in _hmm_round_pairs | rejectattr('ok') -%} {%- if not p.parsed -%} login probe {{ p.probe }} (login_probe_interval={{ p.interval }}, login_probe_total_timeout={{ p.timeout }}) against Prometheus {{ p.prometheus }} (host_metrics_missing_success_window={{ p.window }}, prometheus_scrape_interval={{ p.scrape }}): a value does not parse (probe settings are Go durations greater than 0 and at most 9223372036854775807 ns, such as 60s or 1m30s; the window and scrape interval are single Prometheus durations, such as 150s). {%- else -%} login probe {{ p.probe }} needs a window strictly greater than {{ p.need_seconds }} s (login_probe_interval {{ p.interval }} + login_probe_total_timeout {{ p.timeout }} + the 15 s textfile write + 2 x prometheus_scrape_interval {{ p.scrape }}), but Prometheus {{ p.prometheus }} has host_metrics_missing_success_window={{ p.window }}: HostMetricsMissing would drop out during a data gap and HostDown would page a host that answers SSH. {%- endif %} {% endfor -%} Lengthen host_metrics_missing_success_window (and host_metrics_missing_for, which must stay at least the window + 15 s), shorten the probe interval or timeout, or scrape more often. These cross-host timing settings MUST be stored in inventory (group_vars/host_vars), not supplied only with -e: a later apply of the peer reads inventory hostvars and cannot see overrides from this apply. Apply both roles after changing the inventory. -> {% for p in _hmm_round_pairs | rejectattr('ok') -%} {%- if not p.parsed -%} login probe {{ p.probe }} (login_probe_interval={{ p.interval }}, login_probe_total_timeout={{ p.timeout }}) against Prometheus {{ p.prometheus }} (host_metrics_missing_success_window={{ p.window }}, prometheus_scrape_interval={{ p.scrape }}): a value does not parse (probe settings are Go durations greater than 0 and at most 9223372036854775807 ns, such as 60s or 1m30s; the window and scrape interval are single Prometheus durations, such as 150s).{%- else -%} login probe {{ p.probe }} needs a window strictly greater than {{ p.need_seconds }} s (login_probe_interval {{ p.interval }} + login_probe_total_timeout {{ p.timeout }} + the 15 s textfile write + 2 x prometheus_scrape_interval {{ p.scrape }}), but Prometheus {{ p.prometheus }} has host_metrics_missing_success_window={{ p.window }}: HostMetricsMissing would drop out during a data gap and HostDown would page a host that answers SSH.{%- endif %} {% endfor -%} Lengthen host_metrics_missing_success_window (and host_metrics_missing_for, which must stay at least the window + 15 s), shorten the probe interval or timeout, or scrape more often. These cross-host timing settings MUST be stored in inventory (group_vars/host_vars), not supplied only with -e: a later apply of the peer reads inventory hostvars and cannot see overrides from this apply. Apply both roles after changing the inventory.
jinja[spacing]: playbooks/apply/pilot-access-target-policy-apply.yml#L561
Jinja2 spacing could be improved: pilot-access-target-policy was removed from {{ inventory_hostname }} {{- ' and sshd reloaded without it' if pilot_access_target_dropin_removed is changed else '' }}, but its pre-change snapshot {{ pilot_access_target_dropin_backup }} could not be removed ({{ ((ansible_failed_result.stderr | default('')) or (ansible_failed_result.msg | default(''))) | trim }}). The next run removes it. -> pilot-access-target-policy was removed from {{ inventory_hostname }}{{- ' and sshd reloaded without it' if pilot_access_target_dropin_removed is changed else '' }}, but its pre-change snapshot {{ pilot_access_target_dropin_backup }} could not be removed ({{ ((ansible_failed_result.stderr | default('')) or (ansible_failed_result.msg | default(''))) | trim }}). The next run removes it.
jinja[spacing]: playbooks/apply/pilot-access-target-policy-apply.yml#L561
Jinja2 spacing could be improved: pilot-access-target-policy was removed from {{ inventory_hostname }} {{- ' and sshd reloaded without it' if pilot_access_target_dropin_removed is changed else '' }}, but its pre-change snapshot {{ pilot_access_target_dropin_backup }} could not be removed ({{ ((ansible_failed_result.stderr | default('')) or (ansible_failed_result.msg | default(''))) | trim }}). The next run removes it. -> pilot-access-target-policy was removed from {{ inventory_hostname }}{{- ' and sshd reloaded without it' if pilot_access_target_dropin_removed is changed else '' }}, but its pre-change snapshot {{ pilot_access_target_dropin_backup }} could not be removed ({{ ((ansible_failed_result.stderr | default('')) or (ansible_failed_result.msg | default(''))) | trim }}). The next run removes it.
Go test
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/setup-go@v5, actions/setup-python@v5. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
pilot-cli image
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Thanos retention behavior
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
Root-only ownership tests
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
golangci-lint
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
Playbook lint
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
Go test
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
pilot-cli image
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"

Artifacts

Produced during runtime
Name Size Digest
kjelly~pilot~NQ041Z.dockerbuild
96.6 KB
sha256:ddfd61e330cf00ef75989a8e8f337d44a0f4f47d99609add2a0804ef1bf1faca