forked from WP-API/WP-API
-
Notifications
You must be signed in to change notification settings - Fork 0
Sync Repo #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sync Repo #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently I exposed everything for date parameters. Whether we want just date query or just top level or make date query params top level and then parse a date query, is up for discussion. I am up for improving this, this is a start and something that works.
Testing to see if this fixes failed test on array assertion.
Attempt to fix testing failures by adding new params into the test files themselves. If I am not supposed to do this let me know.
Coolest part was I found out that this year is a leap year from this code and testing! Do /wp/v2/posts/?date_query[0][year]=2015&date_query[0][month]=2&date_query[0][day]=29. If it doesn't fail it's a leap year! Hooray. Added validation. This is still not error proof as I need to handle weird cases with how the top level params work, like when monthnum is specified without year. Maybe chopping top level parameter support would be nice, but would leave this incomplete so I will continue to add error handling for those strange cases.
Revert yoday conditions and white spacing.
Supporting only before and after top level now and filter[date_query] as suggested in #2144. Food for thought: if both filter[date_query] and before or after are specified filter[date_query] will override. Do we want that or do we want before after to override filter[date_query]? Let me know if I interpreted your feedback correctly or if I went in the wrong direction.
Changing after and before parameter to date-time format.
First attempt at adding tests for valid and invalid before after queries.
Second attempt at adding test.
Fixed the tests not sure if they are good enough though. Finally installed PHPUnit and stuff so my PRs should be cleaner in the future! Need feedback if the tests are good enough.
Now we no longer have meta in the core plugin.
Changed before, after description to be less WordPress oriented. Added empty array for $args['date_query'], to prevent PHP Notice
Add before and after date query params to top level query arguments for comments endpoint. Tests for invalid date and valid date included.
Add date query for comments
Add date query to posts endpoints
While this absolutely needs to be fixed before the next release, the failing build is annoyingasf right now.
Skip the failing curie test for now
Remove unused code block in terms controller
Ensure `GET /wp/v2/categories` with out of bounds offset doesn't return results
This is a partial fix to #2331. This fixes the link for the WP REST API TEAM to point to v2 and fixes a link in the readme portion of the plugin to point to the v2 plugin instead of v1. Because there is a plugin named wp-api in the WordPress.org plugin repository it is matching the View Details link to that plugin which has zero relevance to WP REST API v2.
Fix docblock for rest_insert_user
…variables Removed unnecessary global variables from users controller
Bug fix: check if $data[$key][$attribute] is set before unset it
…2331 Fix links in plugin docs #2331
It's a more helpful representation of the comment for callbacks to reference.
Use `$comment` from the database with `rest_insert_comment` action
Fix phpdoc for _add_extra_api_post_type_arguments()
These are all covered by `Tests_REST_API` in core
Remove infrastructure tests from the plugin
Register `description` attribute when registering args from schema
Remove post meta link from post response.
Filter available page templates instead of writing to fs
Support taxonomy collection args on posts endpoint.
kjbenk
pushed a commit
that referenced
this pull request
Mar 18, 2016
Merging commits to keep up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.