Conversation
|
Oh, I knew it would hit me at some point of time 🙃 It was in my ToDo list, to check how the library works with dynamic frameworks. I haven't digged into all internals, but may I ask you how to test these changes? Just add Sorry if questions sound stupid, just thinking whether it's worth to add checks to CI somehow 👀 |
|
Do not pay an attention to failing CI job - it's just because you are external contributor and I still haven't figured out how to fix them for external contributions 😅 |
|
Anyway, I think it's a great addition and I don't want to stop this PR from being merged just because of the questions! Changes look good to me! Thank you for contribution! |
You should specify |
PR concerning New Architecture support in the library 🎉
We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:
or you just want to ask any questions, hit us up on [email protected]
Summary
PR adding
loadmethod needed for dynamic frameworks to work with the library. See facebook/react-native#37274 for more information.