Skip to content

silencing non-exhaustive switch warning#1297

Merged
RoyalPineapple merged 4 commits into
masterfrom
alex/FixError
Aug 1, 2024
Merged

silencing non-exhaustive switch warning#1297
RoyalPineapple merged 4 commits into
masterfrom
alex/FixError

Conversation

@RoyalPineapple

Copy link
Copy Markdown
Contributor

No description provided.

@RoyalPineapple RoyalPineapple marked this pull request as ready for review July 30, 2024 18:24
@RoyalPineapple RoyalPineapple merged commit 4b8224d into master Aug 1, 2024
@justinseanmartin justinseanmartin deleted the alex/FixError branch August 5, 2024 18:03
SimoncelloCT added a commit to SimoncelloCT/KIF that referenced this pull request Aug 21, 2024
* silencing non-exhaustive switch warning (kif-framework#1297)

silencing non-exhaustive switch warning

* Adding support for accessibility custom actions (kif-framework#1295)

* adding support for accessibility custom actions

* introduce tryFindingViewInFrame
- avoid scroll when looking for a view visibility

* remove wrong comment

* improve comments

* add missing disableScroll argument

* introduce usingCurrentFrame() method on KIFUIViewTestActor to disable automatic scroll if needed

* fixes:
- fix wrong parameter name in comments
- add missing methods
- add missing things that prevent us to build for tests

* fix to scrollView behavior:
- with scrollDisabled = YES it now consider only views visible in the current frame, as it was done with TableView and CollectionViews
- make explicit the scrollDisabled argument in recursive calls = NO when we are inside the scrolling section

* add new integration tests for tryFindingViewInFrameWithAccessibilityIdentifier() and usingCurrentFrame()

* Fix bug that was considering an occluded view as tappable

* simplify boolean check and add integration test for broken case

* Revert "simplify boolean check and add integration test for broken case"

This reverts commit 6827225.

* simplify boolean logic of the tappable check

* add missing fromRootView argument

Co-authored-by: Justin Martin <[email protected]>

* Change duplicated accessibilityLabel that was causing flakiness for 2 tests

---------

Co-authored-by: Alex Odawa <[email protected]>
Co-authored-by: Simone Scionti <[email protected]>
Co-authored-by: Justin Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants