Skip to content

Backport: serviceentry: drain Terminating pods from ServiceEntry-derived endpoints#14335

Merged
davidjumani merged 1 commit into
kgateway-dev:v2.3.xfrom
nmnellis:backport/se-terminating-2.3
Jul 1, 2026
Merged

Backport: serviceentry: drain Terminating pods from ServiceEntry-derived endpoints#14335
davidjumani merged 1 commit into
kgateway-dev:v2.3.xfrom
nmnellis:backport/se-terminating-2.3

Conversation

@nmnellis

@nmnellis nmnellis commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

Backport of #14332

Change Type

/kind fix

Changelog

Fixed north-south traffic to a global service continuing to route to a local pod for the duration of its termination grace period. kgateway now drains a terminating pod (deletionTimestamp set) from ServiceEntry-derived endpoints and fails over to a healthy peer-cluster endpoint, consistent with the east-west (ztunnel) path and the Kubernetes Service backend path.

Copilot AI review requested due to automatic review settings June 30, 2026 18:27
@gateway-bot gateway-bot added kind/fix Categorizes issue or PR as related to a bug. release-note labels Jun 30, 2026
Copilot AI reviewed Jun 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@nmnellis nmnellis changed the title serviceentry: drain Terminating pods from ServiceEntry-derived endpoints Backport: serviceentry: drain Terminating pods from ServiceEntry-derived endpoints Jun 30, 2026
@davidjumani
davidjumani enabled auto-merge June 30, 2026 23:35
@davidjumani
davidjumani added this pull request to the merge queue Jun 30, 2026
Merged via the queue into kgateway-dev:v2.3.x with commit 9d570e4 Jul 1, 2026
35 checks passed
@nmnellis
nmnellis deleted the backport/se-terminating-2.3 branch July 1, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@davidjumani davidjumani davidjumani approved these changes

Assignees

No one assigned

Labels

kind/fix Categorizes issue or PR as related to a bug. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nmnellis @davidjumani @gateway-bot