[2.3] fix: use rooted FQDN for xDS cluster address#14296
Merged
puertomontt merged 1 commit intoJun 25, 2026
Conversation
…nsion (kgateway-dev#14291) Signed-off-by: omar <[email protected]>
gateway-bot
added
do-not-merge/description-invalid
kind/fix
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the upstream fix to render the default xDS service address as a rooted FQDN (trailing .) so Envoy strict_dns resolution avoids Kubernetes search-domain expansion on each DNS re-resolution cycle.
Changes:
- Normalize the default
XdsServiceHostto an absolute (rooted) DNS name by ensuring exactly one trailing dot. - Update the deployer e2e assertion to expect the rooted FQDN in the
xds_clustersocket address.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/kgateway/controller/start.go | Ensures the default computed xDS service FQDN is rooted by appending a single trailing dot (idempotently). |
| test/e2e/features/deployer/suite.go | Updates e2e validation to match the rooted FQDN rendered into Envoy’s xds_cluster address. |
puertomontt
enabled auto-merge
June 23, 2026 23:00
alexliu541
approved these changes
Jun 24, 2026
davidjumani
approved these changes
Jun 25, 2026
Merged
via the queue into
kgateway-dev:v2.3.x
with commit Jun 25, 2026
d7a4e97
33 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports 73b6acd / #14291 to v2.3.x.
This uses a rooted FQDN for the default xDS service address so Envoy strict_dns resolution does not expand Kubernetes search domains on each re-resolution cycle.
Change Type
/kind fix
Changelog