feat(tls): allow configuring supported signature algorithms#14282
Merged
davidjumani merged 2 commits intoJul 13, 2026
Conversation
gateway-bot
added
kind/feature
marvin-roesch
force-pushed
the
feat/tls-signature-algorithms
branch
2 times, most recently
from
June 22, 2026 09:59
5c1e45a to
e28b051
Compare
marvin-roesch
marked this pull request as ready for review
June 22, 2026 11:09
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring Envoy TLS signatureAlgorithms via Gateway TLS listener options, wiring the option through kgateway’s TLS IR and into the generated Envoy transport socket configuration, and adds accompanying tests/utilities to exercise the behavior.
Changes:
- Add a new Gateway TLS option annotation (
kgateway.dev/signature-algorithms) and plumb it intoir.TLSConfigand EnvoyTlsParameters. - Extend the curl request utility and frontend TLS e2e suite to test signature algorithm behavior with multiple certificate types.
- Update gateway translator golden inputs/outputs and sslutils unit tests to cover the new TLS option.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/features/frontendtls/testdata/tls-rsa-secret.yaml | Rename RSA test Secret and clarify its purpose for signature-algorithm selection tests |
| test/e2e/features/frontendtls/testdata/tls-ecdsa-p384-secret.yaml | Add ECDSA P-384 test Secret to validate disallowed signature behavior |
| test/e2e/features/frontendtls/testdata/tls-ecdsa-p256-secret.yaml | Add ECDSA P-256 test Secret to validate allowed signature behavior |
| test/e2e/features/frontendtls/testdata/gw.yaml | Update Gateway to reference multiple certs and set the new signature-algorithms TLS option |
| test/e2e/features/frontendtls/suite.go | Add e2e coverage for signature algorithm negotiation and update prerequisite manifests |
| pkg/utils/requestutils/curl/request.go | Add --sigalgs support when generating curl command args |
| pkg/utils/requestutils/curl/option.go | Add signature algorithm option/constants for curl helper |
| pkg/pluginsdk/ir/gw2.go | Extend TLS IR with SignatureAlgorithms |
| pkg/kgateway/translator/sslutils/ssl_utils.go | Parse/apply the signature algorithms TLS option from listener options into IR |
| pkg/kgateway/translator/sslutils/ssl_utils_test.go | Add unit tests for signature algorithms option parsing |
| pkg/kgateway/translator/irtranslator/fc.go | Emit signatureAlgorithms into Envoy TLS parameters during transport socket translation |
| pkg/kgateway/translator/gateway/testutils/outputs/listener-sets/tls-options.yaml | Update golden output to include signatureAlgorithms |
| pkg/kgateway/translator/gateway/testutils/outputs/gateway-only/tls-options.yaml | Update golden output to include signatureAlgorithms |
| pkg/kgateway/translator/gateway/testutils/inputs/listener-sets/tls-options.yaml | Add signature-algorithms option to golden input |
| pkg/kgateway/translator/gateway/testutils/inputs/gateway-only/tls-options.yaml | Add signature-algorithms option to golden input |
| api/annotations/gateway.go | Define the new Gateway TLS option annotation key and docs |
marvin-roesch
force-pushed
the
feat/tls-signature-algorithms
branch
8 times, most recently
from
June 23, 2026 14:03
438bd14 to
862a821
Compare
| containers: | ||
| - name: curl | ||
| image: ghcr.io/kgateway-dev/curl:7.83.1 | ||
| image: curlimages/curl:8.20.0 |
Contributor
Author
There was a problem hiding this comment.
Should be replaced with a new GHCR version of the image at some point, anyway.
Signed-off-by: Marvin Rösch <[email protected]>
…algorithms Signed-off-by: Marvin Rösch <[email protected]>
marvin-roesch
force-pushed
the
feat/tls-signature-algorithms
branch
from
June 24, 2026 06:43
862a821 to
d6b1b8b
Compare
andy-fong
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows users to customize which signature algorithms are supported both for downstream as well as upstream communication.
Note that we use a newer version of the (official)
curlimage as the--sigalgsoption is newer than what's currently pushed toghcr.io/kgateway-dev/curl. At least 8.14.0 is required. This update also meant changing some of the behavior with regards to error codes, as the newer OpenSSL version included in the image appears to deal with mTLS things differently.Related issues: Closes #14281
Change Type
/kind feature
Changelog