fix(listenerpolicy): merge clientCertificateValidation to get correct attachment status#14278
Merged
puertomontt merged 1 commit intoJun 24, 2026
Conversation
marvin-roesch
force-pushed
the
fix/listener-policy-client-validation-merge
branch
from
June 22, 2026 06:18
9d9e9a9 to
0d1666b
Compare
gateway-bot
added
kind/fix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ListenerPolicy attachment status reporting by including clientCertificateValidation in the ListenerPolicy merge logic, so a policy that only configures client certificate validation is still considered “merged/attached” when other ListenerPolicies apply to the same target.
Changes:
- Add
clientCertificateValidationto the ListenerPolicy merge pipeline and record merge origins for it. - Add a new gateway translator regression test case and corresponding input/output golden YAML fixtures.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/kgateway/extensions2/plugins/listenerpolicy/merge.go | Adds merge support for clientCertificateValidation so it contributes to merged policy state and attachment status. |
| pkg/kgateway/translator/gateway/gateway_translator_test.go | Adds a translator test case for per-listener mTLS + policy merging. |
| pkg/kgateway/translator/gateway/testutils/inputs/listener-policy/per-listener-mtls-merge.yaml | New test input fixture covering multiple policies attached to the same listener. |
| pkg/kgateway/translator/gateway/testutils/outputs/listener-policy/per-listener-mtls-merge.yaml | New golden output verifying merged origins metadata and Attached conditions. |
…ct attachment status Signed-off-by: Marvin Rösch <[email protected]>
marvin-roesch
force-pushed
the
fix/listener-policy-client-validation-merge
branch
from
June 22, 2026 07:00
0d1666b to
0878f88
Compare
alexliu541
approved these changes
Jun 24, 2026
alexliu541
left a comment
alexliu541
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix!
puertomontt
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By (shallow-)merging the policy configuration, the policy gets correctly marked as attached.
Related issues: Fixes #14277
Change Type
Changelog