feat: Make rbac creation optional in helm chart#14105
Merged
Merged
Conversation
gateway-bot
added
kind/feature
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Helm values toggle to optionally skip creating cluster-scoped RBAC resources, enabling installs where RBAC is managed externally.
Changes:
- Introduced
rbac.createin chart values (defaulttrue). - Gated
ClusterRoleandClusterRoleBindingtemplate rendering behindrbac.create.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| install/helm/kgateway/values.yaml | Adds rbac.create configuration to control RBAC resource creation. |
| install/helm/kgateway/templates/serviceaccount.yaml | Wraps ClusterRoleBinding generation in an rbac.create conditional. |
| install/helm/kgateway/templates/role.yaml | Wraps ClusterRole generation in an rbac.create conditional. |
Comment on lines
+14
to
16
| {{- if .Values.rbac.create }} | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 |
| kind: ClusterRole | ||
| name: kgateway-{{ .Release.Namespace }} | ||
| apiGroup: rbac.authorization.k8s.io | ||
| {{- end }} |
| @@ -1,3 +1,4 @@ | |||
| {{- if .Values.rbac.create -}} | |||
Contributor
Author
There was a problem hiding this comment.
I'm not sure if the whitespace comments are justified, from my testing there are no extra whitespace added but I wonder if helm template trims them automatically
Contributor
There was a problem hiding this comment.
just a nit but this file and the serviceaccount one use inconsistent trimming
{{- if .Values.rbac.create -}} vs.
{{- if .Values.rbac.create }}
any reason not to make them the same?
| - get | ||
| - list | ||
| - watch | ||
| {{- end }} |
Signed-off-by: nil-scan <[email protected]>
Signed-off-by: nil-scan <[email protected]>
nil-scan
force-pushed
the
helm-rbac-toggle
branch
from
May 25, 2026 04:37
fed7fb1 to
7dd3400
Compare
…helm-rbac-toggle Signed-off-by: nil-scan <[email protected]>
Signed-off-by: nil-scan <[email protected]>
Signed-off-by: nil-scan <[email protected]>
Signed-off-by: nil-scan <[email protected]>
Signed-off-by: nil-scan <[email protected]>
Signed-off-by: nil-scan <[email protected]>
jenshu
reviewed
Jul 13, 2026
Signed-off-by: Jenny Shu <[email protected]>
jenshu
approved these changes
Jul 13, 2026
andy-fong
approved these changes
Jul 13, 2026
davidjumani
enabled auto-merge
July 13, 2026 19:23
davidjumani
approved these changes
Jul 13, 2026
Signed-off-by: Jenny Shu <[email protected]>
davidjumani
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an rbac.create (default true) value to optionally disable the creation of the ClusterRole and ClusterRoleBinding
Change Type
/kind feature
Changelog
Additional Notes