feat: per-commit release artifacts instead of mere moving tag#13876
Merged
davidjumani merged 2 commits intoJul 13, 2026
Conversation
gateway-bot
added
kind/feature
|
This pull request has been marked as stale because of no activity in the last 30 days. It will be closed in the next 5 days unless it is tagged "no stalebot" or other activity occurs. |
github-actions
Bot
added
the
stale
chandler-solo
force-pushed
the
chandler/maintagrace
branch
from
May 18, 2026 19:15
d70fc48 to
797058f
Compare
github-actions
Bot
removed
the
stale
|
This pull request has been marked as stale because of no activity in the last 30 days. It will be closed in the next 5 days unless it is tagged "no stalebot" or other activity occurs. |
github-actions
Bot
added
the
stale
chandler-solo
removed
the
stale
The moving tag being `vX.Y.Z-main`, a tag for both helm chart and docker images. Also, this is a fix: removes a race that could lead to vX.Y.Z-main pointing to an older commit than it should. Signed-off-by: David L. Chandler <[email protected]>
chandler-solo
force-pushed
the
chandler/maintagrace
branch
from
June 23, 2026 14:32
5996f87 to
90a49ab
Compare
chandler-solo
marked this pull request as ready for review
June 23, 2026 15:33
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release GitHub Actions workflow so pushes to main publish per-commit (per-SHA) Helm chart and container image tags, and only “promote” the floating vX.Y.Z-main tags from the workflow run that is still at origin/main HEAD to avoid tag races.
Changes:
- Add a separate
floating_versionoutput and computeVERSIONformainas${floating_version}-${short_sha}to avoid tag collisions between parallelmainruns. - Gate floating Helm chart publication on the commit still being
origin/mainHEAD. - Promote floating container image tags via
docker buildx imagetools createonly when the commit is stillorigin/mainHEAD.
Signed-off-by: David L. Chandler <[email protected]>
davidjumani
reviewed
Jul 13, 2026
| # origin/main advances between the two jobs and leaves the floating chart tag behind the | ||
| # floating image tag. This job needs [setup, goreleaser], so both the per-sha charts | ||
| # (pushed above) and the per-sha images (from goreleaser) already exist by now. | ||
| - name: Promote floating chart and image tags if this commit is still main HEAD |
Contributor
There was a problem hiding this comment.
I think that this should run as a nightly job that promotes the latest tag instead of on a per push to main
davidjumani
approved these changes
Jul 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The moving tag being
vX.Y.Z-main, a tag for both helm chart and docker images.Also, this is a fix: removes a race that could lead to vX.Y.Z-main pointing to an older commit than it should.
ghcr.io cost doesn't increase because public packages on GHCR have no storage or bandwidth quota.
Change Type
/kind feature
Changelog
Additional Notes