Repository navigation
Commit 312875d
authored
ci: run CI on merge groups, and drop the Codecov upload token (#469)
* ci: report CI on merge groups
A merge queue grades the merge commit it builds against the same required
checks the pull request carries. A check whose workflow has no `merge_group`
trigger never reports there, and that is a hang rather than a failure: the
entry waits out the status-check timeout and is evicted.
codeql.yml gets no `merge_group` trigger. Its analysis would run there, but
the code-scanning roll-up check that branch protection names reports only in a
pull-request context (github/codeql-action#1537, open and last confirmed
2026-05-22), so the build would gate nothing. Switching the queue on therefore
means dropping `CodeQL` from the required contexts, where the ruleset's
`code_scanning` rule goes on carrying it for pull requests.
* ci: upload to Codecov with OIDC instead of a stored token
The action's `use_oidc` input takes the job's own short-lived OIDC token and
ignores any token supplied, so `CODECOV_TOKEN` stops being a credential worth
stealing. Every same-repo pull request already ran this workflow with that
secret in reach; a merge queue widens the set of authors who can reshape the
job around it.
The coverage job declares `id-token: write` for it, alongside the
`contents: read` that job-level permissions otherwise drop. Fork pull requests
are unaffected: the action skips OIDC when the head is a fork, which leaves
them on the tokenless path an empty `secrets.CODECOV_TOKEN` already gave them.
No step in the composite action carries `continue-on-error`, so a job that
asks for OIDC without the permission to mint a token fails its upload step,
the coverage job, and the aggregate gate behind it — with an error that names
neither the input nor the permission.1 parent af8d12b commit 312875d
3 files changed
Lines changed: 75 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
138 | 142 | | |
139 | 143 | | |
140 | 144 | | |
| |||
169 | 173 | | |
170 | 174 | | |
171 | 175 | | |
172 | | - | |
| 176 | + | |
173 | 177 | | |
174 | 178 | | |
175 | 179 | | |
| |||
178 | 182 | | |
179 | 183 | | |
180 | 184 | | |
181 | | - | |
| 185 | + | |
182 | 186 | | |
183 | 187 | | |
184 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
114 | 113 | | |
115 | 114 | | |
116 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
6 | 15 | | |
7 | 16 | | |
8 | 17 | | |
| |||
17 | 26 | | |
18 | 27 | | |
19 | 28 | | |
20 | | - | |
| 29 | + | |
21 | 30 | | |
| 31 | + | |
22 | 32 | | |
23 | 33 | | |
24 | 34 | | |
25 | 35 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
30 | 40 | | |
31 | | - | |
32 | | - | |
33 | | - | |
| 41 | + | |
34 | 42 | | |
35 | 43 | | |
36 | | - | |
| 44 | + | |
37 | 45 | | |
38 | 46 | | |
39 | 47 | | |
40 | 48 | | |
41 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
42 | 71 | | |
43 | 72 | | |
44 | 73 | | |
| |||
49 | 78 | | |
50 | 79 | | |
51 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
52 | 89 | | |
53 | 90 | | |
54 | 91 | | |
55 | 92 | | |
56 | 93 | | |
57 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
0 commit comments