Use render prop in withModalHandlers for target#748
Merged
emmatown merged 5 commits intoMar 1, 2019
Conversation
I'm working on code splitting things with suspense and things are breaking because of the findDOMNode calls in react-node-resolver Slightly related to this: @jossmac, i think you'll like this, reactjs/rfcs#97
emmatown
changed the title
jossmac
approved these changes
Mar 1, 2019
jossmac
left a comment
jossmac
left a comment
Member
There was a problem hiding this comment.
LGTM. NodeResolver was a shitty solution to a shitty problem...
Member
Oh god, yes --> that's gonna be sweet! Coupled with the "native" focus management RFC; things are looking good 🙂 |
Member
|
I thought this disclaimer might be helpful for the node resolver package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on code splitting things with suspense and things are breaking because of the findDOMNode calls in react-node-resolver
Slightly related to this: @jossmac, i think you'll like this, reactjs/rfcs#97