Remove Linux only block on sandbox mounts #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@katiewasnothere. Won't let me add you as an assignee, likely need to accept kevins request to add you as an admin |
This change adds support to allow sandbox mounts to work for Windows pods as there used to be a block to only allow these for Linux. Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
windows-sandboxmount
branch
from
8f22c21 to
2f0ddb3
Compare
Collaborator
Author
|
Here's the change that adds support for this in our shim: microsoft/hcsshim#1087 |
dcantah
commented
Sep 22, 2021
Comment on lines
+515
to
+516
| if platform.OS == "linux" { | ||
| mountType = "bind" |
Collaborator
Author
There was a problem hiding this comment.
Suppose there's no harm setting this on Windows also but 🤷♂️. Seems better to just set it only if it's needed
dcantah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to allow sandbox mounts to work for Windows pods
as there used to be a block to only allow these for Linux.
Signed-off-by: Daniel Canter [email protected]