Skip to content

Tighten pr-review rubric, read-only subagents, and worktree base refs - #169

Merged
kevmoo merged 1 commit into
mainfrom
sharpen-saw-wave4
Oct 29, 2026
Merged

kevmoo merged 1 commit into
mainfrom
sharpen-saw-wave4

Conversation

@kevmoo

@kevmoo kevmoo commented Oct 29, 2026

Copy link
Copy Markdown
Owner

Hardens the Dart code-review rubric against primary-constructor false positives and reflection/test-refactor blind spots, locks Deep-review and cold-read subagents to read-only file access, and keeps standalone personal fork worktrees anchored on origin.

  • Dart 3.14+ & test-refactor rubric coverage: Stamps primary-constructor dismissal guidance in skills/pr-review/RUBRIC.md and adds checks for dart:mirrors -> package:analyzer drift-test migrations (google/protobuf.dart#1104), wrapper subtype contract helpers (dart-lang/core#1027), flutter test --platform=chrome entrypoint bundling vs. @TestOn('vm'), and setUp fixture variable shadowing (dart-lang/shelf#547).
  • Strict read-only subagents: Requires tool-restricted read-only subagents with no shell execution in skills/pr-review/SKILL.md (Review Mode: Deep) and skills/cold-read/SKILL.md so subagents never re-run dart test, poll tasks, or shell out to python3/wc.
  • Personal fork base-branch resolution: Updates skills/new-worktree/SKILL.md to prefer origin on standalone ~/github/<owner>/<repo> checkouts (unless remote.upstream.gh-resolved is base) while preserving upstream preference on ~/github/<repo> contribution checkouts.

Hardens the Dart code-review rubric against primary-constructor false positives and reflection/test-refactor blind spots, locks Deep-review and cold-read subagents to read-only file access, and keeps standalone personal fork worktrees anchored on origin.

- Stamp primary-constructor dismissal guidance in skills/pr-review/RUBRIC.md and add checks for dart:mirrors to package:analyzer drift-test migrations (google/protobuf.dart#1104), wrapper subtype contract helpers (dart-lang/core#1027), flutter test --platform=chrome entrypoint bundling vs. @teston('vm'), and setUp fixture variable shadowing (dart-lang/shelf#547).
- Require tool-restricted read-only subagents with no shell execution in skills/pr-review/SKILL.md (Review Mode: Deep) and skills/cold-read/SKILL.md so subagents do not run dart test, poll tasks, or shell out to python3/wc.
- Prefer origin on standalone ~/github/<owner>/<repo> checkouts in skills/new-worktree/SKILL.md (unless remote.upstream.gh-resolved is base) while keeping upstream preference on ~/github/<repo> checkouts.
@kevmoo
kevmoo merged commit 86dad32 into main Oct 29, 2026
9 checks passed
@kevmoo
kevmoo deleted the sharpen-saw-wave4 branch October 29, 2026 02:13
kevmoo added a commit to kevmoo/personal_dotfiles that referenced this pull request Oct 29, 2026
…104)

Updates .agents/.skill-lock.json and tracked .agents/skills manifests after merging kevmoo/scripts.dart#180, kevmoo/kevmoo_skills#168, and kevmoo/kevmoo_skills#169.

- Sync pr-cleanup (with references/duckdb_recipes.md) and pr-triage from kevmoo/scripts.dart#180.
- Sync dart-cleanup, pr-review, cold-read, and new-worktree from kevmoo/kevmoo_skills#168 and kevmoo/kevmoo_skills#169.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant