Repository navigation
Tighten pr-review rubric, read-only subagents, and worktree base refs - #169
Merged
Merged
Conversation
Hardens the Dart code-review rubric against primary-constructor false positives and reflection/test-refactor blind spots, locks Deep-review and cold-read subagents to read-only file access, and keeps standalone personal fork worktrees anchored on origin. - Stamp primary-constructor dismissal guidance in skills/pr-review/RUBRIC.md and add checks for dart:mirrors to package:analyzer drift-test migrations (google/protobuf.dart#1104), wrapper subtype contract helpers (dart-lang/core#1027), flutter test --platform=chrome entrypoint bundling vs. @teston('vm'), and setUp fixture variable shadowing (dart-lang/shelf#547). - Require tool-restricted read-only subagents with no shell execution in skills/pr-review/SKILL.md (Review Mode: Deep) and skills/cold-read/SKILL.md so subagents do not run dart test, poll tasks, or shell out to python3/wc. - Prefer origin on standalone ~/github/<owner>/<repo> checkouts in skills/new-worktree/SKILL.md (unless remote.upstream.gh-resolved is base) while keeping upstream preference on ~/github/<repo> checkouts.
kevmoo
added a commit
to kevmoo/personal_dotfiles
that referenced
this pull request
Oct 29, 2026
…104) Updates .agents/.skill-lock.json and tracked .agents/skills manifests after merging kevmoo/scripts.dart#180, kevmoo/kevmoo_skills#168, and kevmoo/kevmoo_skills#169. - Sync pr-cleanup (with references/duckdb_recipes.md) and pr-triage from kevmoo/scripts.dart#180. - Sync dart-cleanup, pr-review, cold-read, and new-worktree from kevmoo/kevmoo_skills#168 and kevmoo/kevmoo_skills#169.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the Dart code-review rubric against primary-constructor false positives and reflection/test-refactor blind spots, locks Deep-review and cold-read subagents to read-only file access, and keeps standalone personal fork worktrees anchored on
origin.skills/pr-review/RUBRIC.mdand adds checks fordart:mirrors->package:analyzerdrift-test migrations (google/protobuf.dart#1104), wrapper subtype contract helpers (dart-lang/core#1027),flutter test --platform=chromeentrypoint bundling vs.@TestOn('vm'), andsetUpfixture variable shadowing (dart-lang/shelf#547).skills/pr-review/SKILL.md(Review Mode: Deep) andskills/cold-read/SKILL.mdso subagents never re-rundart test, poll tasks, or shell out topython3/wc.skills/new-worktree/SKILL.mdto preferoriginon standalone~/github/<owner>/<repo>checkouts (unlessremote.upstream.gh-resolvedisbase) while preservingupstreampreference on~/github/<repo>contribution checkouts.