Repository navigation
Commit 8fe543a
committed
Drop RawAutocomplete listBox wrapper; test option+isButton precedence
- Remove the Semantics(role: listBox) wrapper from RawAutocomplete. It only
owns the overlay container, not the items, so it would ship role=listbox
with role=button children. Both roles will be assigned together in
material_ui (flutter#194031).
- Add isButton to one option node in the web engine test to lock in that
the explicit role wins over the button flag (the shape material_ui emits).
- Update GenericRole comment wording.1 parent b49211b commit 8fe543a
3 files changed
Lines changed: 7 additions & 10 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine/semantics
- test/engine/semantics
- packages/flutter/lib/src/widgets
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1105 | 1105 | | |
1106 | 1106 | | |
1107 | 1107 | | |
1108 | | - | |
1109 | | - | |
1110 | | - | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
1111 | 1111 | | |
1112 | 1112 | | |
1113 | 1113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3447 | 3447 | | |
3448 | 3448 | | |
3449 | 3449 | | |
3450 | | - | |
| 3450 | + | |
| 3451 | + | |
| 3452 | + | |
3451 | 3453 | | |
3452 | 3454 | | |
3453 | 3455 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
664 | 664 | | |
665 | 665 | | |
666 | 666 | | |
667 | | - | |
668 | | - | |
669 | | - | |
670 | | - | |
671 | | - | |
672 | | - | |
| 667 | + | |
673 | 668 | | |
674 | 669 | | |
675 | 670 | | |
| |||
0 commit comments