add the license field in package.json.#20
Conversation
We are using an automated tool[1] for checking licenses in our packages and their dependencies. The tool works best when packages specify their licenses in the `license` field of the `package.json` files, as written in https://docs.npmjs.com/files/package.json#license. From the LICENSE file in the repo, I assume this package is using the MIT license. Hope you don't mind this change. Thanks! [1] https://www.npmjs.com/package/js-green-licenses
|
I don't mind the change at all and, in fact, appreciate that you'd be willing to put in a PR to resolve an issue. This project is pretty well shelf stable and I haven't modified it in some time. It looks like I've put up a second PR that adjusts the version pins to the last good values. This library has no direct dependencies except for those used to build and test so this shouldn't be impactful to anyone but me. However, I'd appreciate it if you could weigh in on whether or not this will affect your use of the library should I publish a new version to NPM: #21 |
|
Thank you for resolving the jslint issue! That doesn’t affect our use at all. Please go ahead and merge both PRs and publish a new npm. Thanks! |
|
OK. The CI/CD patch and the license annotation for NPM are now published as |
|
@jinwoo Due to some complications related to NPM, I've had to roll forward to |
|
@kevinconway Thank you so much for your help! Yes, we can adjust the semver range accordingly. |
2 participants
We are using an automated tool[1] for checking licenses in our packages
and their dependencies. The tool works best when packages specify their
licenses in the
licensefield of thepackage.jsonfiles, as writtenin https://docs.npmjs.com/files/package.json#license.
From the LICENSE file in the repo, I assume this package is using the
MIT license.
Hope you don't mind this change.
Thanks!
[1] https://www.npmjs.com/package/js-green-licenses