Skip to content

fix(executions): show the execution revision's task source for a recreated flow - #21720

Merged
elevatebart merged 2 commits into
kestra-io:developfrom
Asymtode712:fix/execution-revision-task-source
Oct 28, 2026
Merged

elevatebart merged 2 commits into
kestra-io:developfrom
Asymtode712:fix/execution-revision-task-source

Conversation

@Asymtode712

Copy link
Copy Markdown
Contributor

🔗 Related Issue

Closes #21609

✨ Description

Problem: "Show task source" (from the topology, Gantt or Logs tab of an execution) opened an empty drawer when the flow had been deleted and created again with the same id. It also said "You are seeing an old revision" on the current revision, and on an older execution it could show another revision's source with no warning. This is not a regression: it happens on 1.3.x, 2.0.x and develop.

Cause: TaskEdit found the revision as revisions[revision - 1] and checked "old revision" with revisions.length !== revision. Deleting a flow uses up a revision that the revisions endpoint leaves out, so after a delete and re-create the list (e.g. [1, 2, 4, 5]) no longer lines up with revision numbers.

Fix: Look up the revision by its revision field, and show the warning only when it is not the latest revision in the list. A new spec, TaskEdit.revision.spec.ts, covers the latest and an older revision of a re-created flow. Both cases fail before this change.

Demo

Screen.Recording.2026-10-22.at.10.02.20.PM.mov

🎨 Frontend Checklist

  • Type checking passes (npm run check:types)
  • Code builds without errors (npm run build)
  • Unit tests pass (npm run test:unit)
  • Screenshots or video recordings attached showing the UI changes

📝 Additional Notes

No backend change: the endpoint leaving deleted revisions out is intended. The bug was only in how the UI read the list.

@github-project-automation github-project-automation Bot moved this to To review in Pull Requests Oct 22, 2026
@kestrabot kestrabot Bot added area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors labels Oct 22, 2026
@kestrabot
kestrabot Bot requested review from a team and elevatebart October 22, 2026 16:38

@elevatebart elevatebart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — checked: security, frontend, tests, design system

✅ Ready for your approval — no problem found in the 2 files changed.

No problems found. I only report issues I could prove from the code, so this does not replace your review of the design.


Generated by Claude Code

@elevatebart
elevatebart merged commit 4a153a3 into kestra-io:develop Oct 28, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from To review to Done in Pull Requests Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Empty drawer on "Show task source" from the execution topology

2 participants