Repository navigation
fix(executions): show the execution revision's task source for a recreated flow - #21720
Merged
elevatebart merged 2 commits intoOct 28, 2026
Merged
elevatebart merged 2 commits into
elevatebart merged 2 commits into
Conversation
elevatebart
reviewed
Oct 22, 2026
elevatebart
left a comment
Contributor
There was a problem hiding this comment.
Automated review — checked: security, frontend, tests, design system
✅ Ready for your approval — no problem found in the 2 files changed.
No problems found. I only report issues I could prove from the code, so this does not replace your review of the design.
Generated by Claude Code
elevatebart
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #21609
✨ Description
Problem: "Show task source" (from the topology, Gantt or Logs tab of an execution) opened an empty drawer when the flow had been deleted and created again with the same id. It also said "You are seeing an old revision" on the current revision, and on an older execution it could show another revision's source with no warning. This is not a regression: it happens on 1.3.x, 2.0.x and develop.
Cause:
TaskEditfound the revision asrevisions[revision - 1]and checked "old revision" withrevisions.length !== revision. Deleting a flow uses up a revision that the revisions endpoint leaves out, so after a delete and re-create the list (e.g.[1, 2, 4, 5]) no longer lines up with revision numbers.Fix: Look up the revision by its
revisionfield, and show the warning only when it is not the latest revision in the list. A new spec,TaskEdit.revision.spec.ts, covers the latest and an older revision of a re-created flow. Both cases fail before this change.Demo
Screen.Recording.2026-10-22.at.10.02.20.PM.mov
🎨 Frontend Checklist
npm run check:types)npm run build)npm run test:unit)UIchanges📝 Additional Notes
No backend change: the endpoint leaving deleted revisions out is intended. The bug was only in how the UI read the list.