Skip to content

fix(executions): show full task ids and a narrow comparable duration bar in the gantt - #21149

Merged
elevatebart merged 3 commits into
kestra-io:developfrom
Asymtode712:fix/full-task-ids-and-duration-bar
Oct 19, 2026
Merged

elevatebart merged 3 commits into
kestra-io:developfrom
Asymtode712:fix/full-task-ids-and-duration-bar

Conversation

@Asymtode712

@Asymtode712 Asymtode712 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

🔗 Related Issue

Closes #21066

✨ Description

The Gantt tab gave most of each row to the duration bar and truncated task IDs to fit it (label_project_add_f…). Fixes #18287 as well.

  • The task ID now takes the remaining row width, so it is no longer truncated.
  • Each duration bar is drawn in a narrow fixed column, on one scale from the start to the end of the execution, with the duration next to it.
  • Each row shows when the task started as an offset from the execution start (+1.13s), and the scale is labelled from 0s to the total duration.
  • Each row has a state pill, so a skipped task can be told apart from a successful one.
  • Expanding a row to its attempts and logs works as before.
  • Removed the date tick scale and its helpers, which the new scale replaces.

Screenshots:

Before:

Screenshot 2026-10-17 at 12 03 29 AM

After:

Screenshot 2026-10-16 at 11 54 38 PM

🎨 Frontend Checklist

  • Type checking passes (npm run check:types)
  • Code builds without errors (npm run build)
  • Unit tests pass (npm run test:unit)
  • Screenshots or video recordings attached showing the UI changes

📝 Additional Notes

The same comparable bar is proposed for the topology in #19665 this PR only touches the Gantt.

@Asymtode712

Copy link
Copy Markdown
Contributor Author

@anna-geller @Coding-with-Adam Can you please have a look at this PR

@anna-geller

Copy link
Copy Markdown
Member

Everything from #21066 is covered. A few things to fix before we merge:

  • On narrow screens (below sm), the task ID is squeezed to almost nothing, since the offset, bar, duration and state columns all have a fixed width. Before this PR, the duration was hidden on small screens and the bar could shrink.
  • Long durations such as 1h, 23m, 45.67s don't fit in the duration column and are drawn over the state pill.
  • The offsets and the scale are always in seconds (+10800.00s for a 3h run). Durations should be formatted with durationUtils.humanDuration(), as described in ui/AGENTS.md.
  • The time a task waited before RUNNING is no longer shown as a gap in the bar.
  • The bar itself isn't tested. A test with two rows would be enough to check that both are drawn on one scale.

Smaller ones:

  • item.running is no longer used.
  • The Skipped assertion only checks that KsExecutionStatus renders, which shouldn't be tested according to ui/AGENTS.md.
  • mountGantt duplicates the setup of the existing test, and its current parameter is never passed.
  • The comments in ui/src/utils/filters.spec.ts (lines 44 and 56) are still about the Gantt tick scale.

@Asymtode712

Copy link
Copy Markdown
Contributor Author

@anna-geller Thanks for the review. All points are addressed in the latest commit:

  • Below sm, the offset and duration columns are hidden and the bar is narrower, so the task ID keeps its space. This matches the earlier behaviour.
  • The duration column is wider and clips its content, so long values like 1h 23m 45.67s can't overlap the state pill.
  • Offsets and the scale now use durationUtils.humanDuration(), so a 3h run shows +3h rather than +10800.00s.
  • The time a task waited before RUNNING is a gap in the bar again.
  • I added a two-row test checking both bars sit on one scale and that the wait gap is drawn.
  • I removed the unused running field and the KsExecutionStatus assertion, and mountGantt is now shared with the existing test. The filters.spec.ts comments no longer mention the Gantt.

@anna-geller
anna-geller requested review from a team, elevatebart and loicmathieu and removed request for loicmathieu October 19, 2026 07:24
@elevatebart
elevatebart merged commit 5a448b2 into kestra-io:develop Oct 19, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from To review to Done in Pull Requests Oct 19, 2026
@kestrabot

kestrabot Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

First PR merged 🎉

Great work @Asymtode712! Your change is now part of Kestra. ❤️

Up for another? Our curated list of good first issues is the best place to look, and you can filter it by area/backend, area/frontend or area/plugin depending on what you enjoy. Just comment on the one you pick and wait until we assign it to you before starting.

Thanks again for making Kestra better - and don't forget to ⭐ the repo!


🏅 Claim your Contributor Badge

We want you to be able to showcase your contribution on your GitHub profile page. GitHub's native Achievements section is reserved for GitHub-system badges, so custom open-source badges are displayed in your profile README. Here's how to add yours.

Step 1: Set up your profile README

Skip this if you already have one.

  1. Create a new public repository named exactly after your GitHub username (e.g., myusername/myusername).
  2. Initialize it with a README.
  3. That README.md will now automatically appear at the top of your public profile (github.com/myusername).

Step 2: Add your Contributor Badge

  1. Open your profile repository's README.md and click the Edit (pencil) icon.
  2. Paste the following Markdown snippet wherever you'd like your badge to appear:
### Open Source Contributions
[![Contributor](https://img.shields.io/badge/1st%20PR%20MERGED-KESTRA-1F232C?style=for-the-badge&logo=github&logoColor=200062&labelColor=CDC5FF)](https://kestra.io/community?from=github-badge)

@MilosPaunovic MilosPaunovic added the kind/external Pull requests raised by community contributors label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/external Pull requests raised by community contributors

Projects

Status: Done

4 participants