Repository navigation
Commit 5fa8d1c
committed
fix: bind HTTP sessions to bearer principal, 404 unknown session ids
Address review findings on the streamable HTTP transport:
- F2: store req.principal with each session at initialize; POST/GET/DELETE
carrying another principal's session id now get a bare 403
{"error":"forbidden"} with no MCP protocol details leaked. A rejected
DELETE cannot tear down someone else's session.
- F3: a present-but-unknown Mcp-Session-Id returns 404; 400 is kept only
for missing session ids on non-initialize requests, matching the MCP
streamable HTTP contract.
- F4: npm test invokes node --test via a shell-expanded file list so it
works on Node 18/20 (no --test glob support there). Note: the suggested
`node --test test` was adjusted to `node --test test/*.test.js` —
since Node 21 positional --test args are globs, a bare directory
matches itself and crashes with MODULE_NOT_FOUND (nodejs/node#64555),
which would break npm test on every current Node. The unquoted glob is
expanded by sh into literal paths that every supported Node accepts.
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>1 parent 1506244 commit 5fa8d1c
3 files changed
Lines changed: 75 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
56 | 65 | | |
57 | 66 | | |
58 | 67 | | |
59 | | - | |
| 68 | + | |
60 | 69 | | |
61 | 70 | | |
62 | 71 | | |
| |||
82 | 91 | | |
83 | 92 | | |
84 | 93 | | |
85 | | - | |
86 | | - | |
87 | | - | |
| 94 | + | |
| 95 | + | |
88 | 96 | | |
89 | 97 | | |
90 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
91 | 108 | | |
92 | 109 | | |
93 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | | - | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
41 | | - | |
| 41 | + | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
159 | 181 | | |
160 | 182 | | |
161 | 183 | | |
| |||
190 | 212 | | |
191 | 213 | | |
192 | 214 | | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
193 | 237 | | |
194 | 238 | | |
195 | 239 | | |
| |||
215 | 259 | | |
216 | 260 | | |
217 | 261 | | |
218 | | - | |
| 262 | + | |
219 | 263 | | |
220 | 264 | | |
221 | 265 | | |
| |||
0 commit comments