Skip to content

Conversation

@bole1
Copy link

@bole1 bole1 commented Feb 12, 2021

No description provided.

bole1 and others added 4 commits February 12, 2021 17:23
Further improvements for kernc previous commits.  iid totally removed to prevent troubles with sklearn utils prettyprinting. prettyprinting looks for params when print to repl. Sklearn 0.24 has changed return value after cv, so i changed dict destructuring(a litttle bit dirty)
@kernc kernc mentioned this pull request Feb 23, 2021
@kernc
Copy link
Owner

kernc commented Feb 23, 2021

Thanks for catching and PRing this!

This is required to pass tests/test_searchcv.py
with scikit-learn 0.24+.
@kernc
Copy link
Owner

kernc commented Feb 23, 2021

Ok, I just noticed:

Sklearn 0.24 has changed return value after cv, so i changed dict destructuring(a litttle bit dirty)

Re-added. 👍

@kernc kernc merged commit 3bbbfc2 into kernc:fix_sklearn Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants