-
Notifications
You must be signed in to change notification settings - Fork 1
Update searchcv.py #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Further improvements for kernc previous commits. iid totally removed to prevent troubles with sklearn utils prettyprinting. prettyprinting looks for params when print to repl. Sklearn 0.24 has changed return value after cv, so i changed dict destructuring(a litttle bit dirty)
Sorry, can you show a before and after example? The reason the parameter is still accepted and deprecated is not to break existing code, or at least to break it with a warning. |
with your commit: |
|
I see. 👍 I think a better fix would be assigning: self.iid = iid # for sklearn pprint |
Your fix is better |
|
Continued in #2. |
Further improvements for kernc previous commits. iid totally removed to prevent troubles with sklearn utils prettyprinting. prettyprinting looks for params when print to repl. Sklearn 0.24 has changed return value after cv, so i changed dict destructuring(a litttle bit dirty)