oauth: get signing key from provider#236
Merged
Merged
Conversation
cainlevy
approved these changes
Jan 7, 2024
cainlevy
approved these changes
Jan 10, 2024
cainlevy
left a comment
cainlevy
left a comment
Member
There was a problem hiding this comment.
Looks fine to me. Do you have a preference between the new ENV var or adding a third value to the existing credentials?
Contributor
Author
|
Not a strong one @cainlevy - I guess maybe including with credentials is slightly more straightforward to document as long as we note the 3rd signing key segment is only respected after v1.X.Y. |
Member
|
I don't have a strong preference here either. I trust your discretion on it. |
Contributor
Author
|
I took a crack at including with credentials and think I like it better. Feels like less code, and there was a natural spot for an error in the credential parsing response @cainlevy |
AlexCuse
added a commit
to AlexCuse/authn-server
that referenced
this pull request
Mar 23, 2024
This reverts commit 899a32b.
AlexCuse
added a commit
that referenced
this pull request
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.