adds split_dataset utility #16398
Merged
copybara-service[bot] merged 24 commits intokeras-team:masterfrom May 9, 2022
Merged
Conversation
google-ml-butler
Bot
added
the
keras-team-review-pending
gbaned
removed
the
keras-team-review-pending
fchollet
reviewed
Apr 11, 2022
Collaborator
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Adding unit tests will help you make the use cases more concrete.
… having same shape
fchollet
reviewed
Apr 16, 2022
Collaborator
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Thanks for the update!
Collaborator
|
Please let me know when you'd like me to review (and you can also graduate the PR from draft to ready). |
google-ml-butler
Bot
added
the
keras-team-review-pending
Contributor
Author
|
@fchollet I Incorporated the requested changes. The code passes both Pylint and Bazel tests. The pull request is now ready for review. |
rchao
added
keras-team-review-pending
fchollet
reviewed
Apr 22, 2022
fchollet
approved these changes
Apr 28, 2022
Collaborator
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Excellent, I think we're good! Thanks for the update.
I added a comment but we can probably just fix it in post.
google-ml-butler
Bot
added
kokoro:force-run
ready to pull
fchollet
removed
the
keras-team-review-pending
fchollet
approved these changes
May 5, 2022
google-ml-butler
Bot
added
kokoro:force-run
ready to pull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mentioned in #16394