Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

Fix Quickstart#228

Merged
oleg-nenashev merged 2 commits intokeptn:masterfrom
agardnerIT:master
Mar 17, 2022
Merged

Fix Quickstart#228
oleg-nenashev merged 2 commits intokeptn:masterfrom
agardnerIT:master

Conversation

@agardnerIT
Copy link
Copy Markdown
Contributor

@agardnerIT agardnerIT commented Mar 14, 2022

This PR will fix the Quickstart tutorial as mentioned in #227

Lessons learned

  1. The auto remediation use case cannot be run without the multi-stage delivery because podtatohead-production won't exist. Docs should be updated to mention that the flow is: Keptn hello world > multi stage delivery > auto remediation

Things Fixed

  • Updated images to latest ones & now uses keptncontrib repo images not images stored in a @johannes-b's repo.
  • Added a check in autoremediation shell script to only install JES if it doesn't already exist

Outstanding Items Before Merging PR

  • Currently the JES pod fails with The connection to the server localhost:8080 was refused @christian-kreuzberger-dtx will probably immediately spot the issue that I'm missing :)
{
  "data": {
    "message": "Job job-executor-service-job-6e3b00dc-5586-45d7-9ce6-635c-1 failed: job job-executor-service-job-6e3b00dc-5586-45d7-9ce6-635c-1 failed. Reason: BackoffLimitExceeded, Message: Job has reached the specified backoff limit\n\nLogs: \nThe connection to the server localhost:8080 was refused - did you specify the right host or port?\n",
    "project": "podtatohead",
    "result": "fail",
    "service": "helloservice",
    "stage": "production",
    "status": "errored"
  },
  "id": "4a31e0f7-43c7-448a-af8b-02bb069489e4",
  "shkeptncontext": "2461cd3f-5c4f-48bc-8063-f32ba5f7f5cb",
  "shkeptnspecversion": "0.2.4",
  "source": "shipyard-controller",
  "specversion": "1.0",
  "time": "2022-03-14T09:53:43.722Z",
  "triggeredid": "c063b994-dad8-4e0c-a565-62644dca9f0c",
  "type": "sh.keptn.event.production.remediation.finished"
}

@agardnerIT
Add check for existing JES deployment
78e3bff 
Add check for existing JES deployment

Signed-off-by: Adam Gardner <[email protected]>
@oleg-nenashev oleg-nenashev added the type:bug Something isn't working label Mar 17, 2022
oleg-nenashev
oleg-nenashev approved these changes Mar 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks for the fix!

@oleg-nenashev oleg-nenashev merged commit 3ef456f into keptn:master Mar 17, 2022
@agardnerIT
Copy link
Copy Markdown
Contributor Author

agardnerIT commented Mar 17, 2022

Please re-open until we reach DoD above

@oleg-nenashev oleg-nenashev mentioned this pull request Mar 17, 2022
Closed
@oleg-nenashev
Copy link
Copy Markdown
Member

oleg-nenashev commented Mar 17, 2022

oops, have not noticed before-the-merge warning. Should I revert?

oleg-nenashev added a commit that referenced this pull request Mar 17, 2022
@oleg-nenashev
Revert "Fix Quickstart (#228)"
22bbe37 
This reverts commit 3ef456f.
@oleg-nenashev oleg-nenashev mentioned this pull request Mar 17, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AloisReitbauer AloisReitbauer Awaiting requested review from AloisReitbauer AloisReitbauer is a code owner

@thisthat thisthat Awaiting requested review from thisthat thisthat is a code owner

1 more reviewer

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type:bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agardnerIT @oleg-nenashev