This repository was archived by the owner on Dec 21, 2023. It is now read-only.
feat: Use latest prometheus-service SLI placeholders#226
Merged
christian-kreuzberger-dtx merged 1 commit intomasterfrom Mar 22, 2022
Merged
feat: Use latest prometheus-service SLI placeholders#226christian-kreuzberger-dtx merged 1 commit intomasterfrom
christian-kreuzberger-dtx merged 1 commit intomasterfrom
Conversation
Signed-off-by: Christian Kreuzberger <[email protected]>
christian-kreuzberger-dtx
requested review from
AloisReitbauer and
thisthat
as code owners
oleg-nenashev
approved these changes
Mar 17, 2022
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Sorry, I missed that. Would appreciate approval in #217
Please feel free to go ahead and merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Reason: With Prometheus-Service 0.7.3 we are finally able to use
$DEPLOYMENTin the SLI config, and no longer need multiple SLI files.IMPORTANT NOTE: This also needs to be reflected in keptn/tutorials. Once this PR is merged and released (e.g., keptn/[email protected]), we need to update tutorials, e.g.:
changes to