This repository was archived by the owner on Dec 21, 2023. It is now read-only.
fix: Fixed retrying bug even if opening bridge is successful#221
Merged
TannerGilbert merged 1 commit intokeptn:masterfrom Jan 2, 2022
TannerGilbert:fix/retrying-open-bridge-on-success
Merged
fix: Fixed retrying bug even if opening bridge is successful#221TannerGilbert merged 1 commit intokeptn:masterfrom TannerGilbert:fix/retrying-open-bridge-on-success
TannerGilbert merged 1 commit intokeptn:masterfrom
TannerGilbert:fix/retrying-open-bridge-on-success
Conversation
Signed-off-by: TannerGilbert <[email protected]>
TannerGilbert
requested review from
AloisReitbauer and
thisthat
as code owners
TannerGilbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
expose-keptn.shfile that retries the opening of the Keptn bridge even though it was already open. This is due to a missing break statement.How to test
Run
curl -SL https://raw.githubusercontent.com/keptn/examples/master/quickstart/expose-keptn.sh | bash