feat: drop support for transpiling the code that is being prevaled#59
Merged
Conversation
It cause way too many weird bugs that take a TON of time to track down. BREAKING CHANGE: Code that's being prevaled will no longer be transpiled. You should either transpile it ahead of time or only write the code in a version of JavaScript that runs natively in the version of node you're running.
kentcdodds
force-pushed
the
pr/stop-transpiling
branch
from
June 27, 2018 21:38
cc08dfb to
7498a95
Compare
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 108 106 -2
Branches 22 22
=====================================
- Hits 108 106 -2
Continue to review full report at Codecov.
|
Owner
Author
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Code that's being prevaled will no longer be transpiled. You should either transpile it ahead of time or only write the code in a version of JavaScript that runs natively in the version of node you're running.
Why:
It cause way too many weird bugs that take a TON of time to track down.
How:
Checklist: