Add CRA note to caveats#83
Merged
kentcdodds merged 1 commit intokentcdodds:masterfrom Oct 3, 2018
Merged
Conversation
facebook/create-react-app#2730 (comment) We don't want users thinking they have to purge the cache, as this will be very detrimental to their rebuild speed.
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 80 80
Branches 19 19
=====================================
Hits 80 80Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Oct 3, 2018
Owner
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Cool! Thanks. Maybe we could add documentation on what people can do in their own webpack/Babel config to avoid the problem for themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Note that Create React App does not suffer from a common problem using Macros.
Why:
facebook/create-react-app#2730 (comment)
We don't want users thinking they have to purge the cache, as this will be very detrimental to their rebuild speed.
It's also important because these configuration values are out of their reach; ejecting to "fix" this would be unnecessary.