Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kentcdodds/babel-plugin-macros
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.4.4
Choose a base ref
...
head repository: kentcdodds/babel-plugin-macros
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.4.5
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jan 7, 2019

  1. fix(config): pass options to cosmiconfig according to 5.x.x API (#100) 

    **What**:
I've updated babel-plugin-macros' usage of cosmiconfig to use the 5.x.x API.

**Why**:
This project's dependency on cosmiconfig was updated from 4.x.x to 5.x.x, but without changing the calls to cosmiconfig.

Thus, the configuration override was no longer being read (packageProp was not overridden, thus using `babelMacros` in package.json no longer worked).

The tests still passed as they only checked `babel-plugin-macros.config.js`, which was read by default by cosmiconfig: https://github.com/davidtheclark/cosmiconfig#searchplaces
    @lPadier
    lPadier authored and Kent C. Dodds committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    9edac40 View commit details
    Browse the repository at this point in the history
Loading