-
Notifications
You must be signed in to change notification settings - Fork 27
Drop direct babel dependency + allowing dynamicImport, objectRestSpread #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c418ee6
8a29495
b41bb53
a49a41a
95e8929
e1a3617
672a39c
2bca6a6
fd14376
d1f659c
d145491
4b1dde0
86513fd
7056abb
a885367
e68d98d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,10 +29,7 @@ | |
| "author": "Kent C. Dodds <[email protected]> (http://kentcdodds.com/)", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "babel-core": "^6.26.3", | ||
| "babel-plugin-macros": "^2.2.1", | ||
| "babel-register": "^6.26.0", | ||
| "babel-template": "^6.26.0", | ||
| "require-from-string": "^2.0.2" | ||
| }, | ||
| "devDependencies": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,6 +89,7 @@ pluginTester({ | |
| // @codegen | ||
| /* comment */`, | ||
| }, | ||
| 'codegen`module.exports = "var ALLCAPS = \'ALLCAPS\'"`', | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added this test for the ALLCAPS template regression in babel7.
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We would need to refactor https://github.com/babel-utils/babel-plugin-tester to be able to accept babel-core as an option so we can provide our own version.
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've implemented this feature so we can test this properly now if you like. |
||
| ], | ||
| }) | ||
|
|
||
|
|
@@ -133,5 +134,15 @@ pluginTester({ | |
| \\\` | ||
| \` | ||
| `, | ||
| 'accepts babels parser options for generated code': { | ||
| babelOptions: { | ||
| filename: __filename, | ||
| parserOpts: {plugins: ['flow', 'doExpressions']}, | ||
| }, | ||
| code: ` | ||
| // @codegen | ||
| module.exports = "var fNum: number = do { if(true) {100} else {200} };" | ||
| `, | ||
| }, | ||
| }, | ||
| }) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run
npx kcd-scripts formatto fix all the formatting? I think you editor messed up a few things...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm.... This is weird... It's formatting things completely different for lists... Did prettier change how it formats lists?