Skip to content

Issue #8141: Dash validator allowing None values in addition to floats - #1

Merged
kenmaca merged 1 commit into
masterfrom
pr-dash-verification-8141
Mar 14, 2017
Merged

kenmaca merged 1 commit into
masterfrom
pr-dash-verification-8141

Conversation

@kenmaca

@kenmaca kenmaca commented Mar 6, 2017

Copy link
Copy Markdown
Owner

Validators for dashed linestyles now allow None as an allowed value along with floats if optional allow_none kwarg flag in validate_nseq_float.

Other validators that use validate_nseq_float aren't affected, so this bugfix won't have any breaking changes.

Validators for dashed linestyles now allow None as an allowed value along with floats through optional `allow_none` kwarg in validate_nseq_float. Other validators that use validate_nseq_float arent affected
@kenmaca

kenmaca commented Mar 6, 2017

Copy link
Copy Markdown
Owner Author

TravisCI and AppVeyor tests passed on official PR: matplotlib#8196

@QuLogic

QuLogic commented Mar 7, 2017

Copy link
Copy Markdown

You don't want to open/merge the PR here; your master branch will get out of sync with upstream's.

@kenmaca

kenmaca commented Mar 7, 2017

Copy link
Copy Markdown
Owner Author

Oh, this fork is really just an internal repo for our school project since the course provided one is private and we'd like a way to both submit real PR's while having a convenient listing of changes made in a single place to show our instructor.

Thanks for the advice!

@kenmaca
kenmaca merged commit 776a278 into master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants