buildifier test passes on failing build files #88
Description
Maybe I don't understand how to run this, but my naive experiements suggest some issue:
git clone
cd examples/simple
edit BUILD, mess up formatting
bazel run //:buildifier.check shows diffs with corrections
bazel test //:buildifier.test reports PASSED
The build file is:
load("@buildifier_prebuilt//:rules.bzl", "buildifier", "buildifier_test")
buildifier(
name = "buildifier.check",
exclude_patterns = [
"./.git/*"],
lint_mode = "warn",
lint_warnings = [
"-cc-native",
],
mode = "diff",
)
buildifier_test(
name = "buildifier.test",
srcs = ["BUILD"],
lint_mode = "warn",
)
sh_binary(
name = "hello_world",
srcs = ["hello_world.sh"],
)
sh_test(
name = "hello_world_test",
srcs = ["hello_world_test.sh"],
data = [
":hello_world",
],
deps = [
"@bazel_tools//tools/bash/runfiles",
],
)
Thanks!