remove the outdated datasets argument to combine_by_coords

TomNicholas · TomNicholas · commit 85f5d2c25f4c · 2021-07-22T21:07:32.000-04:00
diff --git a/xarray/core/combine.py b/xarray/core/combine.py
@@ -635,16 +635,14 @@ def _combine_single_variable_hypercube(
     return concatenated
 
 
-# TODO remove empty list default param after version 0.19, see PR4696
 def combine_by_coords(
-    data_objects=[],
+    data_objects,
     compat="no_conflicts",
     data_vars="all",
     coords="different",
     fill_value=dtypes.NA,
     join="outer",
     combine_attrs="no_conflicts",
-    datasets=None,
 ):
     """
     Attempt to auto-magically combine the given datasets (or data arrays)
@@ -849,14 +847,6 @@ def combine_by_coords(
         precipitation  (y, x) float64 0.4376 0.8918 0.9637 ... 0.5684 0.01879 0.6176
     """
 
-    # TODO remove after version 0.19, see PR4696
-    if datasets is not None:
-        warnings.warn(
-            "The datasets argument has been renamed to `data_objects`."
-            " In future passing a value for datasets will raise an error."
-        )
-        data_objects = datasets
-
     if not data_objects:
         return Dataset()
 
