Fix quit submenu on macOS tray icon#582
Fix quit submenu on macOS tray icon#582TheZ3ro merged 1 commit intokeepassxreboot:feature/macos-minimize-onclosefrom weslly:feature/macos-minimize-onclose
Conversation
|
I don't really like this workaround. I prefer finding out why If there are no alternative I will accept this |
|
@TheZ3ro it still doesn't work if I remove the icon, but when I remove the According to Qt docs the menu role can only be changed before the action is added to the menu bar so I don't think there's a way to reuse |
|
Why don't you set the MenuRole inside a I mean, adding the #ifdef before line 188 |
|
Only macOS uses the MenuRole and this problem only happens on macOS so it would still get the MenuRole anyway. The workaround only duplicates the quit action on macOS, other OSes still use I agree the workaround is ugly but I don't think there's a way to reuse |
|
Sorry, I was meaning something like: And using |
|
That would work, but |
|
Ok, I was missing those Issues. So I think I can accept this |
Description
Add the quit submenu to macOS tray icon and disable redundant toggle window action when clicking on the icon.
How has this been tested?
Local tests
Types of changes
Checklist: