Skip to content

Compare window title with entry URLs during autotype matching.#556

Merged
louib merged 3 commits intokeepassxreboot:developfrom
jensrutschmann:autotype-compare-with-entry-url
May 13, 2017
Merged

Compare window title with entry URLs during autotype matching.#556
louib merged 3 commits intokeepassxreboot:developfrom
jensrutschmann:autotype-compare-with-entry-url

Conversation

@jensrutschmann
Copy link
Copy Markdown
Contributor

@jensrutschmann jensrutschmann commented May 8, 2017

Description

Compare window title with entry URLs during autotype matching (in addition to the entry title).

Motivation and context

Sometimes websites don't set the title to something that can be used for looking up entries in the database, for example:
Website: https://bugs.kde.org/show_bug.cgi?id=379616 (randomly picked issue)
Window title: "Bug list - Mozilla Firefox"
The entry title for this website would probably be something like "KDE Bugzilla", so there's no way the entry could be found. Instead of manually adding window hints, comparing the URL would make the entry match the window - if the browser adds the url / domain to the window title. This can be achieved with add-ons such as:

I'm using these add-ons together with the changes from this PR instead of keepasshttp (which is much more complex to set up but has more features of course).

Resolves #537

How has this been tested?

  • Added unit tests
  • Manually tried while running on Linux

Types of changes

  • ✅ New feature (non-breaking change which adds functionality)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ Compile with -DWITH_ASAN=ON. [REQUIRED]
    • Travis built successfully with this flag.
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have added tests to cover my changes.

TODO

  • Currently this is an extension to the title matching, toggled by config option 'AutoTypeEntryTitleMatch'.
    • Should we adapt the i18n for this option?
    • Should this be another option? Probably there's no value in a separate option.
    • Should the existing option be renamed? I don't know how config option migration would need to be done.
  • Please carefully review my pointer usage - I haven't done much C programming in the past.

Copy link
Copy Markdown
Contributor

@TheZ3ro TheZ3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@TheZ3ro
Copy link
Copy Markdown
Contributor

TheZ3ro commented May 11, 2017

Just one thing @jensrutschmann
In the SettingsWidgetGeneral.ui file can you change the text to
Use entry title and URL to match windows for global Auto-Type

@jensrutschmann
Copy link
Copy Markdown
Contributor Author

Hey @TheZ3ro I've updated the UI file.

I could also update the German translation in transifex, but should I wait until this PR has been merged?

@TheZ3ro
Copy link
Copy Markdown
Contributor

TheZ3ro commented May 11, 2017

@jensrutschmann yes, you must wait until this PR is merge and we update the translation files over on Transifex with the 2.2 release

@louib louib merged commit 9a59a12 into keepassxreboot:develop May 13, 2017
@phoerious phoerious added this to the v2.2.0 milestone May 14, 2017
@guihkx
Copy link
Copy Markdown
Contributor

guihkx commented May 17, 2017

This is what I was looking for (I'm a new KeepassXC user)! However, wouldn't it be better to have this as a separated option?

When I use KeePass on Windows I use these Auto-Type options plus
this extension for Chrome... That way, I can use Auto-Type on some third-party websites with no conflicts. For example, if I have two entries: 'Steam' and 'Steam Tools' (two different websites), auto-type will have a conflict... So, matching only URLs is the best option.

if I want to use Auto-Type on a regular desktop program, on KeePass I just have to add a tag containing the exact window title of the program, and then Auto-Type will work beautifully with no conflicts.

droidmonkey added a commit that referenced this pull request Jun 25, 2017
- Added YubiKey 2FA integration for unlocking databases [#127]
- Added TOTP support [#519]
- Added CSV import tool [#146, #490]
- Added KeePassXC CLI tool [#254]
- Added diceware password generator [#373]
- Added support for entry references [#370, #378]
- Added support for Twofish encryption [#167]
- Enabled DEP and ASLR for in-memory protection [#371]
- Enabled single instance mode [#510]
- Enabled portable mode [#645]
- Enabled database lock on screensaver and session lock [#545]
- Redesigned welcome screen with common features and recent databases [#292]
- Multiple updates to search behavior [#168, #213, #374, #471, #603, #654]
- Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480]
- Fixed auto-type errors on Linux [#550]
- Prompt user prior to executing a cmd:// URL [#235]
- Entry attributes can be protected (hidden) [#220]
- Added extended ascii to password generator [#538]
- Added new database icon to toolbar [#289]
- Added context menu entry to empty recycle bin in databases [#520]
- Added "apply" button to entry and group edit windows [#624]
- Added macOS tray icon and enabled minimize on close [#583]
- Fixed issues with unclean shutdowns [#170, #580]
- Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515]
- Compare window title to entry URLs [#556]
- Implemented inline error messages [#162]
- Ignore group expansion and other minor changes when making database "dirty" [#464]
- Updated license and copyright information on souce files [#632]
- Added contributors list to about dialog [#629]
@phoerious phoerious added pr: new feature Pull request adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new feature Pull request adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-Type new feature

5 participants