Skip to content

More compact search widget#471

Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom
francoisferrand:searchWidget
Apr 6, 2017
Merged

More compact search widget#471
droidmonkey merged 1 commit intokeepassxreboot:developfrom
francoisferrand:searchWidget

Conversation

@francoisferrand
Copy link
Copy Markdown
Contributor

@francoisferrand francoisferrand commented Apr 5, 2017

  • Move the search icon (with popup menu) and clear icon inside the line edit
  • Move the search widget to the right-side of toolbar

This makes the toolbar less clutered, and the search widget has a more usual look.

screenshot_2017-04-05_11-10-11

@phoerious
Copy link
Copy Markdown
Member

The clear button was outside intentionally. Qt has the problem that the clear button only has a 16x16 resolution even when your font size is bigger, so it looks very pixelated.

@francoisferrand
Copy link
Copy Markdown
Contributor Author

If I understand correctly, the 'intention' was just to avoid using the setClearButtonEnabled() feature, and create a 'real' button instead: so I could update my patch to insert a 'clearIcon' action on the right side, with the same icon as before, would this be acceptable?

@phoerious
Copy link
Copy Markdown
Member

Yeah, that would be acceptable.

* Move the search icon (with popup menu) and clear icon inside the
line edit
* Move the search widget to the right-side of toolbar
@francoisferrand
Copy link
Copy Markdown
Contributor Author

Ok, done (and fixed tests)

@droidmonkey
Copy link
Copy Markdown
Member

Is the drop down menu preserved?

@francoisferrand
Copy link
Copy Markdown
Contributor Author

yes, drop down menu works as before.

@droidmonkey
Copy link
Copy Markdown
Member

This is fancy pants, great work!

@droidmonkey droidmonkey merged commit 86e88c1 into keepassxreboot:develop Apr 6, 2017
@phoerious phoerious added this to the v2.2.0 milestone Apr 9, 2017
@francoisferrand francoisferrand deleted the searchWidget branch May 26, 2017 12:44
droidmonkey added a commit that referenced this pull request Jun 25, 2017
- Added YubiKey 2FA integration for unlocking databases [#127]
- Added TOTP support [#519]
- Added CSV import tool [#146, #490]
- Added KeePassXC CLI tool [#254]
- Added diceware password generator [#373]
- Added support for entry references [#370, #378]
- Added support for Twofish encryption [#167]
- Enabled DEP and ASLR for in-memory protection [#371]
- Enabled single instance mode [#510]
- Enabled portable mode [#645]
- Enabled database lock on screensaver and session lock [#545]
- Redesigned welcome screen with common features and recent databases [#292]
- Multiple updates to search behavior [#168, #213, #374, #471, #603, #654]
- Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480]
- Fixed auto-type errors on Linux [#550]
- Prompt user prior to executing a cmd:// URL [#235]
- Entry attributes can be protected (hidden) [#220]
- Added extended ascii to password generator [#538]
- Added new database icon to toolbar [#289]
- Added context menu entry to empty recycle bin in databases [#520]
- Added "apply" button to entry and group edit windows [#624]
- Added macOS tray icon and enabled minimize on close [#583]
- Fixed issues with unclean shutdowns [#170, #580]
- Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515]
- Compare window title to entry URLs [#556]
- Implemented inline error messages [#162]
- Ignore group expansion and other minor changes when making database "dirty" [#464]
- Updated license and copyright information on souce files [#632]
- Added contributors list to about dialog [#629]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants