More compact search widget#471
Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom Apr 6, 2017
Merged
Conversation
afc8ca3 to
9c254d5
Compare
Member
|
The clear button was outside intentionally. Qt has the problem that the clear button only has a 16x16 resolution even when your font size is bigger, so it looks very pixelated. |
Contributor
Author
|
If I understand correctly, the 'intention' was just to avoid using the setClearButtonEnabled() feature, and create a 'real' button instead: so I could update my patch to insert a 'clearIcon' action on the right side, with the same icon as before, would this be acceptable? |
Member
|
Yeah, that would be acceptable. |
* Move the search icon (with popup menu) and clear icon inside the line edit * Move the search widget to the right-side of toolbar
9c254d5 to
ba5c82c
Compare
Contributor
Author
|
Ok, done (and fixed tests) |
Member
|
Is the drop down menu preserved? |
Contributor
Author
|
yes, drop down menu works as before. |
Member
|
This is fancy pants, great work! |
droidmonkey
approved these changes
Apr 6, 2017
droidmonkey
added a commit
that referenced
this pull request
Jun 25, 2017
- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the toolbar less clutered, and the search widget has a more usual look.