Ignore group expansion and other minor changes when marking database as dirty#464
Merged
droidmonkey merged 3 commits intokeepassxreboot:developfrom Apr 21, 2017
Merged
Conversation
droidmonkey
reviewed
Apr 4, 2017
| </item> | ||
| <item> | ||
| <widget class="QCheckBox" name="ignoreGroupExpansionCheckBox"> | ||
| <property name="text"> |
Member
There was a problem hiding this comment.
Do we want to expand this definition to be "Don't mark database as modified for non-data changes (e.g., expanding groups)"? This setting could apply to other things that we implement such as sort order of columns, visible columns, etc.
Member
Author
There was a problem hiding this comment.
@droidmonkey I updated the text for the new option. I don't think there's any other database change that would qualify as non-data change at the moment. Maybe reordering groups, but then again it's not something that a user does when simply looking for a password, so I think it should still mark the db as dirty.
droidmonkey
changed the title
droidmonkey
approved these changes
Apr 21, 2017
droidmonkey
added a commit
that referenced
this pull request
Jun 25, 2017
- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]
phoerious
added
pr: new feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to ignore group expansion.
Motivation and context
#446
How has this been tested?
Locally + unit tests.
Types of changes
Checklist: