Add auto-type {CLEARFIELD} by weslly · Pull Request #427 · keepassxreboot/keepassxc

weslly · 2017-03-23T13:46:27Z

closes #426

Description

This PR add support for the auto-type {CLEARFIELD} command.

Progress

macOS
Linux
Windows

Types of changes

✅ New feature (non-breaking change which adds functionality)

Checklist:

✅ I have read the CONTRIBUTING document. [REQUIRED]
✅ My code follows the code style of this project. [REQUIRED]
✅ All new and existing tests passed. [REQUIRED]
✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

weslly · 2017-03-25T22:10:49Z

This is ready for review.

rockihack · 2017-03-27T10:46:54Z

Keepass uses Home; Shift+End; Backspace to clear fields.
The character A might depend on the keyboard layout...
I implemented it for windows and mac os:
rockihack/keepassx@1662678
rockihack/keepassx@29bf74f

weslly · 2017-03-27T15:05:49Z

@rockihack I'm not sure about windows, but OSX uses ⌘+A as the standard to the "Select all" action in any layout, including non-latin input methods such as japanese or korean. Also, the home and end keys don't work the same way in many apps since they aren't even available in most mac keyboards.

weslly · 2017-03-27T15:35:37Z

@rockihack Also, it seems Windows uses the same virtual keycode values for any layout, so it wouldn't make any difference with other layouts, I just tested with AZERTY and it didn't.

But I agree we should probably change it to Home; Shift+End; Backspace on Windows (only) for the sake of compatibility with Keepass 2.x behavior.

TheZ3ro · 2017-03-27T15:56:15Z

On linux with AZERTY layout I can reproduce @rockihack bug.
Anyway using Home on multi-line input field will place the caret at start of the current line so only the current line will be deleted (instead of all the content with CTRL+A)

rockihack · 2017-03-27T16:05:27Z

Clears the contents of the edit control that currently has the focus (only single-line edit controls).

http://keepass.info/help/base/autotype.html

To be compatible with keepass you should use Home; Shift+End; Backspace.
Atleast on windows you can use Ctrl+Home; Ctrl+Shift+End; Backspace to clear multiline edits.

rockihack · 2017-03-27T16:07:56Z

src/autotype/mac/AutoTypeMac.cpp

+
+    m_platform->sendKey(Qt::Key_Control, true, true);
+    m_platform->sendKey(Qt::Key_A, true, true);
+    m_platform->sendKey(Qt::Key_Control, false, true);


You should press and release keys in inverse order.

I did in the first commit but it's not how OSX recognizes the key sequence in an unsimulated ⌘+A:

Yes, but look at the event type FlagsChanged.
What does it show for the clear field sequence?

Look at the example here: https://developer.apple.com/reference/coregraphics/1456564-cgeventcreatekeyboardevent

What does it show for the clear field sequence?

The example doesn't seem to follow the same sequence of a real keystroke

Actually it could be the way I usually type, I release the modifier key before releasing the character key. Not sure if it's how most people do or not...

I'll change it to be like the example

TheZ3ro · 2017-03-27T16:09:38Z

Ctrl+Home; Ctrl+Shift+End; Backspace to clear multiline edits.

I think this is the best alternative

weslly · 2017-03-27T16:22:27Z

Unless the goal is 100% compatibility with Keepass 2.x, I think we should support multi-line edits, like <textarea> on HTML forms.

TheZ3ro · 2017-03-27T16:27:31Z

@weslly @rockihack

Unless the goal is 100% compatibility with Keepass 2.x, I think we should support multi-line edits, like <textarea> on HTML forms.

I agree but also we should support multiple keyboard layout, and Ctrl+Home; Ctrl+Shift+End; Backspace does the job (at least on linux where Ctrl+A doesn't works with an Azerty layout)

weslly · 2017-03-27T16:34:00Z

~~Actually looks like OSX uses ⌘+A but not the same keycodes with Azerty. I'll fix it.~~
Fixed.

rockihack · 2017-03-27T16:58:43Z

src/autotype/xcb/AutoTypeXCB.cpp

    event.keycode = keycode;
-    SendEvent(&event, KeyPress);
-    SendEvent(&event, KeyRelease);
+    if (isKeyDown) {


With this change, modifiers will be pressed and released for each key event.
Instead of modifing the code here, you can use SendEvent and SendModifier directly in execClearField.

phoerious · 2017-04-09T14:05:27Z

src/autotype/mac/AutoTypeMac.cpp

+    m_platform->sendKey(Qt::Key_Down, true, Qt::ShiftModifier | Qt::ControlModifier);
+    m_platform->sendKey(Qt::Key_Down, false, Qt::ShiftModifier | Qt::ControlModifier);
+    m_platform->sendKey(Qt::Key_Control, false, Qt::ShiftModifier);
+    m_platform->sendKey(Qt::Key_Shift, false);


Can someone explain this key sequence to me?

@phoerious

Command Up - Move the cursor to the beginning of the field

Shift Command Down - Select the text between the cursor and the end of the field

Delete - Delete the selection

Ok. Looks fine to me then.

- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]

weslly changed the title ~~WIP: Add auto-type {CLEARFIELD}~~ Add auto-type {CLEARFIELD} Mar 25, 2017

TheZ3ro approved these changes Mar 26, 2017

View reviewed changes

TheZ3ro added the bug label Mar 26, 2017

TheZ3ro added this to the v2.2.0 milestone Mar 26, 2017

rockihack reviewed Mar 27, 2017

View reviewed changes

TheZ3ro requested review from droidmonkey and phoerious April 1, 2017 12:17

weslly and others added 11 commits April 8, 2017 02:13

Add auto-type {CLEARFIELD} on mac

32fe049

Rename ClearField keypress helper function

720ae94

Add auto-type {CLEARFIELD} on Windows

28678f4

Add auto-type {CLEARFIELD} on XCB

7620395

Add command modifier support for AutoTypePlatformMac::sendKey

268f091

Use AutoTypePlatformWin::sendKey instead of creating a new function

36250f5

use QT key instead of native ones

ea1ffe7

More accurate hotkey sequence

6c1f023

support different keyboard layout

a6e142d

Change auto-type sequence on mac to support other keyboard layouts

eefea54

Change windows clearfield key sequence to avoid keyboard layout errors

0aa20f9

phoerious reviewed Apr 9, 2017

View reviewed changes

phoerious approved these changes Apr 9, 2017

View reviewed changes

droidmonkey approved these changes Apr 9, 2017

View reviewed changes

droidmonkey merged commit c0f62e5 into keepassxreboot:develop Apr 9, 2017

weslly deleted the feature/autotype-clearfield branch April 9, 2017 15:57

weslly mentioned this pull request Apr 20, 2017

OSX El Capitan 10.11.6 compilation issue #516

Closed

phoerious added pr: bugfix Pull request fixes a bug and removed bug labels Nov 22, 2024

Uh oh!

Conversation

weslly commented Mar 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Progress

Types of changes

Checklist:

Uh oh!

weslly commented Mar 25, 2017

Uh oh!

rockihack commented Mar 27, 2017

Uh oh!

weslly commented Mar 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weslly commented Mar 27, 2017

Uh oh!

TheZ3ro commented Mar 27, 2017

Uh oh!

rockihack commented Mar 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheZ3ro commented Mar 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weslly commented Mar 27, 2017

Uh oh!

TheZ3ro commented Mar 27, 2017

Uh oh!

weslly commented Mar 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

weslly commented Mar 23, 2017 •

edited

Loading

weslly commented Mar 27, 2017 •

edited

Loading

rockihack commented Mar 27, 2017 •

edited

Loading

TheZ3ro commented Mar 27, 2017 •

edited

Loading

weslly commented Mar 27, 2017 •

edited

Loading