Show application icon in Plasma Wayland sessions#3777
Merged
phoerious merged 1 commit intokeepassxreboot:release/2.5.1from Nov 3, 2019
Merged
Show application icon in Plasma Wayland sessions#3777phoerious merged 1 commit intokeepassxreboot:release/2.5.1from
phoerious merged 1 commit intokeepassxreboot:release/2.5.1from
Conversation
This is required to show the keepassxc icon on Wayland windows in a Plasma Wayland session. kwin_wayland fetches application icons from .desktop files and it expects the desktop filename to be set on the QGuiApplication instance. Without this, kwin sets a generic Wayland icon as fallback.
Member
|
You can change the target branch. No need for a new PR. |
phoerious
approved these changes
Nov 3, 2019
Contributor
Author
I needed to change the source branch, though (since it was |
Member
|
You rebase to the new branch, force-push and then change the branch you want to merge into at the top of the PR. |
scoroi
pushed a commit
to scoroi/keepassxc
that referenced
this pull request
Nov 10, 2019
This is required to show the keepassxc icon on Wayland windows in a Plasma Wayland session. kwin_wayland fetches application icons from .desktop files and it expects the desktop filename to be set on the QGuiApplication instance. Without this, kwin sets a generic Wayland icon as fallback.
phoerious
added a commit
that referenced
this pull request
Nov 11, 2019
Added - Add programmatic use of the EntrySearcher [#3760] - Explicitly clear database memory upon locking even if the object is not deleted immediately [#3824] - macOS: Add ability to perform notarization of built package [#3827] Changed - Reduce file hash checking to every 30 seconds to correct performance issues [#3724] - Correct formatting of notes in entry preview widget [#3727] - Improve performance and UX of database statistics page [#3780] - Improve interface for key file selection to discourage use of the database file [#3807] - Hide Auto-Type sequences column when not needed [#3794] - macOS: Revert back to using Carbon API for hotkey detection [#3794] - CLI: Do not show protected fields by default [#3710] Fixed - Secret Service: Correct issues interfacing with various applications [#3761] - Fix building without additional features [#3693] - Fix handling TOTP secret keys that require padding [#3764] - Fix database unlock dialog password field focus [#3764] - Correctly label open databases as locked on launch [#3764] - Prevent infinite recursion when two databases AutoOpen each other [#3764] - Browser: Fix incorrect matching of invalid URLs [#3759] - Properly stylize the application name on Linux [#3775] - Show application icon on Plasma Wayland sessions [#3777] - macOS: Check for Auto-Type permissions on use instead of at launch [#3794]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to show the keepassxc icon on Wayland windows in a
Plasma Wayland session.
kwin_wayland fetches application icons from .desktop files and it
expects the desktop filename to be set on the QGuiApplication instance.
Without this, kwin sets a generic Wayland icon as fallback.
Type of change
Testing strategy
Start keepassxc on a Plasma Wayland session with/without this patch and check its window icon.
Checklist: