Conversation
There was a problem hiding this comment.
Nice addition. However, you should also add a keyboard shortcut. Unfortunately, Ctrl+N is already taken, but maybe Ctrl+Shift+N?
I always try to create a new DB with a shortcut, but for some stupid reason, there is none.
And BTW the branch should be named feature/203-new-icon-in-toolbar or so. ;-)
|
I think we should assign a new KeySequence to the newEntry event and use CTRL+N for the new database. Yeah, I've used an old branch I was working on for other ui-related issues and forgot to change. |
|
Fine by me. Ctrl+N for new DB and Ctrl+Shift+N for new entry? |
|
Yeah, Done |
|
Fixed a typo with a force push |
|
I'm not sure about the wholesale reassignment of cmd-n. If you don't have a database open, then cmd-n can't possibly do anything useful as new-entry, and thus mapping it to new-database is a good idea. But, if you have a database open, the most common action is new-entry, and thus I'd argue in favor of it doing that instead of new-database. (With cmd-shift-n as a reasonable alternate for this case.) |
|
I would argue that Ctrl+N is almost always used for creating a new document and a document in our case is a database, not a single entry. |
|
It could be contextual. If you are not inside an active database CTRL+N could be new database. If you ARE inside an active database CTRL+N could be new entry. |
|
I was thinking about that solution as well, but I suppose that would be rather confusing. That would maybe be a practicable solution if only one of those shortcuts worked at the same time. But you can always create a new database, even if you already have one. |
|
While you can create a database if you have one, you are unlikely to want to, and thus it really shouldn't be the default action. One could make the half-argument that an entry A slightly different model would be that ^N always creates a new entry, and if you don't have a database what it does is creates the new database and inserts a new entry into it so that you're always creating a new entry :-) -- that might be easier to reason through... |
|
I would leave it as is, but we can discuss switching the shortcuts. |
|
That's fine. I'd strongly encourage you to make ^N the new entry key*. Users may have 2-3 databases, but they'll have hundreds of entries. They're much more likely to be creating entries than databases, and if they've been using KeyPass or others in the past (including KeyChain.app), that's the action that they expect. For reference, macOS has 3 levels of commands:
For KeyChain.app, new item is in the first category, and new database is in the last. -- A keychain is the KeyChain.app equivalent of a KeePass database.
|
|
If we want to make a behavior based shortcut (that is pretty confusing for users already), I think we should go for "^N default shortcut for create a new entry, if no database opened, open a database and create entry." Otherwise (if we don't want a behavior based) we should decide and stick with that. |
|
My general preference is just ^N = new-entry, but short of that, the other behavior that @TheZ3ro doesn't mind would be my second choice. |
|
Having used develop for a while now, I think it is actually a good idea to switch the hotkeys. Use Ctrl+N for new entry and Ctrl+Shift+N for new database. |
|
I will revert this PR this afternoon |
|
Just make a new PR that switches the shortcuts. |
|
Yep (reverting always mean doing a new PR) |
- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]
|
From a usability point of view, the omission of the "New Document" icon in the toolbar was one of the greater improvements. As creation of new databases is something users rather seldomly do it's not necessary to expose it prominently. Thus said, I am curious what has been your rationale for adding it again? |
|
@MasinAD for new users it's fundamental to have a new database icon right in front of their eyes. Also, if you open a document with LibreOffice or Geany, the first button is a new document button |
|
I do understand that new users should have an easy and obvious way to
create a new database but you already have the "empty" view with a big
button to create a new database – which is a really great way to introduce
new users to KeePassXC.
But the icon will only be used once or twice for almost any user and just
takes screen estate after that. The comparison with LibreOffice or Geany
doesn't convince me because working with documents and creating many of
those is a core workflow of those programs but creating databases or
keyrings is not for a password manager. That said, I noticed the discussion
about hotkeys. It might seem sensible to use ctrl+n for a new database as a
database is currently seen as the analogy to a document in other
applications. I would rather see creation of a database analogous to
configuring an e-mail account in an e-mail client. You'd do it at least
once but very rarely more often than just a handful of times.
|
|
Thanks for your feedback but i don't foresee this PR being reverted without major community backlash. |
|
Is there some kind of forum where to discuss such decisions? I understand the Github issue tracker might not be the best fit for it. As to my motivation: I administrate about 100 client PCs of which about half are Ubuntu clients. Most of my users are computer literate but no enthusiasts. I need to provide them tools with as little friction in day-to-day use as possible. KeePassX works nice, but is lacking in a few areas (you might have noticed ;-) ). KeePassXC has tons of improvements, but I get the feeling the design decisions are not always … well reasoned, in lack of better words. At my workplace, we have some UX experts. If you want I could ask them to take a look at the current state of the KeePassXC UI. |
|
No, there is no forum. We prefer to keep discussions in one place. |
|
Well, what had been your reasoning to re-introduce that button, then? Might
be a good start. :-)
2017-07-16 19:33 GMT+02:00 Janek Bevendorff <[email protected]>:
… No, there is no forum. We prefer to keep discussions in one place.
We are open to well-founded UX concerns, but they have to be beyond "I
like that better" or "I think people would prefer…" or "In our firm, users
don't understand…"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#289 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABfDXQmfDWA_odQ_SqgYv64gYP_2lObqks5sOkltgaJpZM4L-J9y>
.
|
|
Consistency with other applications. |
|
If you really don't like it just comment it out and compile the application for your firm. Bantering back and forth on this PR is very fruitless at this point. |
phoerious
added
pr: new feature
5 participants
Description
insert newDatabase icon in ToolBar, fix #203
How Has This Been Tested?
Screenshots (if appropriate):
(this screenshot shows the 16x16 icon, I've added a new commit with the correct 22x22 icon)
Types of changes
Checklist: