Skip to content

Support for OnlyKey#2754

Closed
onlykey wants to merge 3 commits intokeepassxreboot:developfrom
trustcrypto:okcore
Closed

Support for OnlyKey#2754
onlykey wants to merge 3 commits intokeepassxreboot:developfrom
trustcrypto:okcore

Conversation

@onlykey
Copy link
Copy Markdown
Contributor

@onlykey onlykey commented Feb 28, 2019

Per comment by @droidmonkey on issue #2064 I have created a separate library for OnlyKey (okpers) it is compatible with ykpers without conflict as the function names have been changed. For example, yk_open_first_key() will open the first Yubikey and ok_open_first_key() will open the first OnlyKey or Yubikey. The library is available here - https://github.com/trustcrypto/yubikey-personalization/releases/tag/v1.19.4 I will put together more detailed docs if this is merged.

@droidmonkey
Copy link
Copy Markdown
Member

@onlykey unfortunately I cannot merge this without the linked libraries being available in the various MSYS2, Ubuntu, and Homebrew repositories. Is there any way we can ditch the library and just have a side-load bare minimum process?

@onlykey
Copy link
Copy Markdown
Contributor Author

onlykey commented Jun 28, 2019

@droidmonkey So there is a better way now, lets scrap this PR I will do another one. The better way is that Yubikey approved my request to have a separate function in https://github.com/Yubico/yubikey-personalization to specify the USB device vendorid/productid. So no custom library is needed now, all you need is the next ykcore release, the problem here is that they haven't done a release and when I asked last time they said there was no release scheduled. So the new function is sitting in https://github.com/Yubico/yubikey-personalization master branch but you guys use the pre-compiled yubikey and ykpers libraries. I was hoping they would generate a new release by now but the last one is from Feb.

So here is my plan.

@droidmonkey
Copy link
Copy Markdown
Member

droidmonkey commented Jun 28, 2019

Awesome 👍
That is absolutely the better way to do this.

@droidmonkey droidmonkey removed this from the v2.5.0 milestone Jun 29, 2019
@droidmonkey droidmonkey removed their request for review June 29, 2019 01:55
@onlykey onlykey mentioned this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants