Conversation
|
@onlykey unfortunately I cannot merge this without the linked libraries being available in the various MSYS2, Ubuntu, and Homebrew repositories. Is there any way we can ditch the library and just have a side-load bare minimum process? |
|
@droidmonkey So there is a better way now, lets scrap this PR I will do another one. The better way is that Yubikey approved my request to have a separate function in https://github.com/Yubico/yubikey-personalization to specify the USB device vendorid/productid. So no custom library is needed now, all you need is the next ykcore release, the problem here is that they haven't done a release and when I asked last time they said there was no release scheduled. So the new function is sitting in https://github.com/Yubico/yubikey-personalization master branch but you guys use the pre-compiled yubikey and ykpers libraries. I was hoping they would generate a new release by now but the last one is from Feb. So here is my plan.
|
|
Awesome 👍 |
Per comment by @droidmonkey on issue #2064 I have created a separate library for OnlyKey (okpers) it is compatible with ykpers without conflict as the function names have been changed. For example, yk_open_first_key() will open the first Yubikey and ok_open_first_key() will open the first OnlyKey or Yubikey. The library is available here - https://github.com/trustcrypto/yubikey-personalization/releases/tag/v1.19.4 I will put together more detailed docs if this is merged.