Merged
Conversation
phoerious
requested changes
Jan 26, 2017
Member
phoerious
left a comment
phoerious
left a comment
There was a problem hiding this comment.
Looks good so far, but the attribute name list panel should have a sane default and min-width. It's great that it's resizable now, but it still has the tiny default size it had before and I can even drag it further to the left until it disappears.
Member
Author
|
Yah i need to look into sizing properties a little more. Almost everything in keepassxc is set to what i call "shrinkwrap mode" |
droidmonkey
force-pushed
the
feature/attribute-enhancements
branch
from
ffab299 to
27d815f
Compare
droidmonkey
force-pushed
the
feature/attribute-enhancements
branch
from
27d815f to
8047bc2
Compare
Member
Author
|
@phoerious please take a look at the new fixes |
Contributor
|
Can we include gui-tests before merging? |
Member
Author
|
Yes sorry, forgot about those. |
droidmonkey
force-pushed
the
feature/attribute-enhancements
branch
from
8b3ce24 to
c13fec9
Compare
droidmonkey
force-pushed
the
feature/attribute-enhancements
branch
from
c13fec9 to
c89e6c7
Compare
* Allow protected attributes to be hidden * Entry area is resizable
droidmonkey
force-pushed
the
feature/attribute-enhancements
branch
from
c89e6c7 to
78b10a9
Compare
Member
Author
|
ping @phoerious |
phoerious
approved these changes
Mar 7, 2017
Member
phoerious
left a comment
phoerious
left a comment
There was a problem hiding this comment.
Just one minor style thing. Otherwise it looks ok as is.
src/gui/entry/EditEntryWidget.cpp
Outdated
| QModelIndex index = m_advancedUi->attributesView->currentIndex(); | ||
| if (!m_history && index.isValid()) { | ||
| QString key = m_attributesModel->keyByIndex(index); | ||
| if (state) |
Member
There was a problem hiding this comment.
This should have braces, because with the comment lines, it looks more like two lines.
droidmonkey
added a commit
that referenced
this pull request
Jun 25, 2017
- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #111 and fixes #45
Motivation and Context
Attribute entry area was ugly and boring. It is now awesome (or at least slightly better)! The protected view is powered by the already existing protected attributes in the entry class.
How Has This Been Tested?
Manual testing
Screenshots (if appropriate):
Types of changes
Checklist: