Verifying passwords against HIBP#1520
Closed
louib wants to merge 1 commit intokeepassxreboot:developfrom
Closed
Conversation
Contributor
|
Personally I would do a Side note: This PR is based on an offline SHA1 database of pwned password, instead of #1083 (comment) that use the service API |
Member
|
Personally I would not add sha1 to the CryptoHash class, however convienent. Either make the gcrypt calls directly from the cli code or create a new class (SHA1Hash). We don't want sha1 related to crypto in any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New CLI command to verify a password database against the HIBP database dump.
Motivation and context
Was inspired by https://news.ycombinator.com/item?id=16446020
How has this been tested?
Locally.
Screenshots (if appropriate):
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]