New feature: hexadecimal password generator#1248
New feature: hexadecimal password generator#1248chuinul wants to merge 3 commits intokeepassxreboot:developfrom
Conversation
|
I believe there was a suggestion to use the existing A-Z and a-z buttons to delineate upper and lower case hex. |
|
Yes there was. I don't know which solution is better. I began with this one because I felt using the existing buttons was a little confusing since it is not their original purpose. Besides, in my opinion, those two extra radio buttons are acceptable since they are on the same line. There is no waste of space. But, yes, using the existing buttons is probably good as well. Only the other class of characters will be left grey. You tell me what you prefer. |
|
Eh just keep it the way it is |
src/gui/PasswordGeneratorWidget.cpp
Outdated
| m_ui->checkBoxUpper->setChecked(true); | ||
| m_ui->checkBoxLower->setChecked(false); | ||
| } | ||
| else { |
src/gui/PasswordGeneratorWidget.cpp
Outdated
| m_ui->checkBoxExcludeAlike->setChecked(false); | ||
| m_ui->checkBoxEnsureEvery->setChecked(false); | ||
| } | ||
| else { |
|
Might i suggest to include a custom character text field instead of a dedicated checkbox? I chose this method as well in MacPass to enable unexpected character sets |
|
Would this work by putting in |
|
Currently you would have to put in 0123456789abcdefABCDEF since I did not add any parsing mechanism. But I guess this is not that hard to add. It's flexible but not very comfortable. |
|
What about adding What do you think? |
|
@TheZ3ro I find those partially redundant buttons From my point of view, the root of our problems is summarized in #820. Granted the password generator of KeePass is way too complicated. But the more features we will be asked to add, the more we will need some kind of (predefined and user defined) profiles. I have no solution to implement a flexible enough and easy to use password generator. But probably once done, that hexadecimal feature will be integrated to it rendering that workaround PR obsolete. |
|
I think using the How many times average Joe will need hex passwords? Anyway, It's fine having the checkbox |
|
This has become overcome by #1841 |
4 participants
Description
This PR adds a button in the password generator to select only hexadecimal characters, upper- or lower-cased depending on the need of the user.
Motivation and context
This solves #789, which states that "There are some [ed.: absurd?] use cases where one is required to generate a password which only consists of HEX characters".
I tried to keep it as light as possible. Because in the generator each button represents a class of disjoints characters, I've chosen to add another checkbox instead of another button.
How has this been tested?
There are GUI tests, checking that buttons and checkbox are properly greyed and checked when generating a hexadecimal password, and that the generated password contains only hexadecimal characters.
I've also tested it manually on Linux Mint 18.2.
Screenshots (if appropriate):
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]