Skip to content

[PRE-RELEASE] Simultaneous editing doesn't work properly #3651

@FlorentDotMe

Description

@FlorentDotMe

Expected Behavior

When two or more users are working on a same keepassx database, creating, editing or deleting actions are not conflicting between users without being notified.

Current Behavior

Two users or more simultaneously editing an entry (same or different) will result on only the first to validate the modification will have it saved in the database.

Possible Solutions

  • Before saving modifications to an entry, make sure KeepassXC reloaded the database in background if it was modified.
  • Add a notification feature showing a message when multiple users are manipulating the same entry at the same time to avoid unexpected data override.

Steps to Reproduce

User A and User B are using KeepassXC on their own computer and are modifying the same keepassx database which is stored on a CIFS server.

  1. User A is editing the new entry E1.
  2. At the same time, User B is adding a new entry E2.
  3. User A is the first to validate his entry E1. Database is updated.
  4. Then User B validates his entry E2. Database is NOT updated.
  5. Finally, only E1 was added to the database and E2 is lost.

Context

We noticed this bug since PR #3612 allows us to have multiple users working on the same keepassx database. This bug was certainly present before the PR.

We only use Linux systems, so couldn't try to reproduce the bug on Windows systems.

Debug Info

KeePassXC - Version 2.5.0-snapshot
Build Type: Snapshot
Revision: 4cc06f9

Qt 5.11.3
Debugging mode is disabled.

Operating system: Debian GNU/Linux 10 (buster)
CPU architecture: x86_64
Kernel: linux 4.19.0-5-amd64

Enabled extensions:

  • Auto-Type

Cryptographic libraries:
libgcrypt 1.8.4

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions