Expected Behavior

When trying to open a database, I press the button for showing the password I'm currently entering. The password is then shown. When I enter a wrong password, I either expect

1. the password to be turned back to dots and the button to revert to the unpressed state or
2. the password to remain visible and the button to stay in pressed state.

Current Behavior

The password is turned back to dots, but the button remains in pressed state. If I want to reveal the password again, I have to press the button twice. The first time the button reverses from pressed state to unpressed, and the password remains shown as dots. The second time the password is revealed again, and the button toggles to pressed state.

Yes, this sounds exactly like #2344, but I can still reproduce it on the current release of KeepassXC.

Steps to Reproduce

1. Start KeepassXC
2. Enter a wrong password but don't submit
3. Press the button for revealing the password
4. Submit the wrong password
5. Observe that the password is turned back into dots while the button stays in pressed state.
6. Klick the button to reveal the password. Observe that the password stays as-is, meaning as dots, while the button reverses to unpressed state.

Debug Info

KeePassXC - Version 2.4.1
Revision: 7bafe65

Qt 5.12.2
Debugging mode is disabled.

Operating system: Windows 10 (10.0)
CPU architecture: x86_64
Kernel: winnt 10.0.17763

Enabled extensions:

• Auto-Type
• Browser Integration
• SSH Agent
• KeeShare (signed and unsigned sharing)
• YubiKey

Cryptographic libraries:
libgcrypt 1.8.4